Skip to content

Remove uniqueness requirement for district nces id #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamiebenstead merged 5 commits into from
Jan 19, 2026
Merged

Remove uniqueness requirement for district nces id #652

jamiebenstead merged 5 commits into from
Jan 19, 2026

Conversation

@jamiebenstead
Copy link
Contributor

@jamiebenstead jamiebenstead commented Jan 16, 2026

What's changed?

  • Removes uniqueness validation for district_nces_id

Copilot AI review requested due to automatic review settings January 16, 2026 16:35
@cla-bot cla-bot bot added the cla-signed label Jan 16, 2026
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the uniqueness validation for district_nces_id from the School model to allow multiple schools to share the same NCES district identifier.

Changes:

  • Removed the model-level uniqueness validation for district_nces_id in the School model

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-fix-remove-ns5upk January 16, 2026 16:51 Inactive
@jamiebenstead jamiebenstead requested a review from Copilot January 16, 2026 16:52
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@jamiebenstead jamiebenstead requested a review from Copilot January 16, 2026 16:58
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jamiebenstead jamiebenstead merged commit 84d0d8e into main Jan 19, 2026
6 checks passed
@jamiebenstead jamiebenstead deleted the fix-remove-district_nces_id-uniqueness-validation branch January 19, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@zetter-rpf zetter-rpf zetter-rpf approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamiebenstead @zetter-rpf @raspberrypiherokubot