Integrate RVCA and enhance AR features with fixes#307
Open
doranteseduardo wants to merge 36 commits intomainfrom
Open
Integrate RVCA and enhance AR features with fixes#307doranteseduardo wants to merge 36 commits intomainfrom
doranteseduardo wants to merge 36 commits intomainfrom
Conversation
Added the missing guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes across the AR rendering pipeline, session management, and material handling. The most significant changes enhance AR session initialization safety, improve plane anchor update logic, expand AR platform support, add new rendering capabilities for scene depth, and refine material emission defaults.
AR Platform & Session Management Improvements:
VROCloudAnchorProviderandVROGeospatialAnchorProvider. [1] [2]VROARScene: bothinitDeclarativeSessionandinitImperativeSessionnow guard against double-initialization and log warnings instead of crashing. [1] [2]VROARScenenow include both horizontal and vertical planes.AR Plane Anchor Update & Throttling:
Scene Depth Rendering Enhancements:
_sceneDepthTarget) toVROChoreographer, capturing scene depth after each base render pass for use in the next frame, enabling advanced effects that require previous frame depth sampling. [1] [2] [3] [4] [5] [6] [7]Camera and Geospatial Data Access:
getCameraImageYmethod toVROARFramefor direct access to the tightly-packed Y (luma) plane of the camera image, improving low-level camera data handling.headingAccuracytoVROGeospatialPosefor more precise geospatial pose confidence reporting. [1] [2] [3]Material & Rendering Pipeline Fixes:
VROMaterialto black, ensuring no emission unless explicitly set.setShaderUniforminVROMaterialto callupdateSubstrateTextures()instead ofupdateSubstrate(), preventing unnecessary shader binding recreation.VROMaterialShaderBindingfor consistency. [1] [2]Other Notable Cleanups:
VROARScenemethods for cleaner production logs. [1] [2] [3]DepthOnlyocclusion mode for AR rendering, enabling depth sensing without visual occlusion.These changes collectively improve the reliability, performance, and extensibility of the AR rendering and session management subsystems.