[MOD-13164] [MOD-13481] Introduce VecSimDiskParams Wrapper for Disk-Based Vector Indexes
#887
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add VecSimHNSWDiskParams to AlgoParams
VecSimHNSWDiskParams: replace hnsw alg parametrs with HNSWParams struct introduce TieredHNSWDiskParams have TieredHNSWDiskParams in the union of TieredIndexParams
meiravgri
commented
Jan 12, 2026
| void *storage; // Opaque pointer to disk storage | ||
| const char *indexName; | ||
| size_t indexNameLen; | ||
| void *logCtx; |
Collaborator
Author
There was a problem hiding this comment.
void *logCtx is in VecSimParams
move disk params to VecSimParamsDisk
meiravgri
changed the title
VecSimParamsDisk Wrapper for Disk-Based Vector Indexes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 97.13% 97.09% -0.05%
==========================================
Files 129 129
Lines 7615 7493 -122
==========================================
- Hits 7397 7275 -122
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
typedef struct {
void *storage; // Opaque pointer to disk storage
const char *indexName;
size_t indexNameLen;
} VecSimDiskContext;
split VecSimParamsDisk to:
typedef struct {
VecSimParams *indexParams;
VecSimDiskContext *diskContext;
} VecSimDiskParams;
meiravgri
changed the title
VecSimParamsDisk Wrapper for Disk-Based Vector IndexesVecSimDiskParams Wrapper for Disk-Based Vector Indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the disk index creation API to support any disk-based algorithm.
Problem:
storage,indexName) was embedded inVecSimHNSWDiskParamsSolution:
VecSimDiskContextfor disk metadata (storage, indexName)VecSimDiskParamswrapper that accepts anyVecSimParams*+ disk contextVecSimHNSWDiskParams- useHNSWParamsdirectlyTieredHNSWDiskParamsto support Tiered HNSW Disk