Refactor AWS session creation with profile support#53
Open
alberttwong wants to merge 4 commits into
Open
Conversation
alberttwong
requested review from
ajGingrich,
kurtfm,
mar1boroman,
sagile and
thomasefthymiou78
as code owners
Refactor AWS session creation with profile support
Add mock STS client to test cases for AWS services.
ajGingrich
reviewed
Apr 2, 2026
| identity = sts.get_caller_identity() | ||
| print(f"Using AWS identity: {identity['Arn']}") | ||
|
|
||
| print(f"Requesting information for the {section} nodes") |
Collaborator
There was a problem hiding this comment.
this is duplicated down below
Collaborator
There was a problem hiding this comment.
@alberttwong Can you remove this duplicate log?
ajGingrich
reviewed
Apr 2, 2026
| aws_session_token = None | ||
|
|
||
| # Create session with credentials | ||
| session = boto3.Session( |
Collaborator
There was a problem hiding this comment.
won't this remove the ability to authenticate using access keys directly?
Author
There was a problem hiding this comment.
I had codex add this back in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restored direct AWS credential authentication from config.ini in ecstats.py (line 474). process_aws_account() now passes aws_access_key_id and aws_secret_access_key into boto3.Session(...) when those settings are present, includes aws_session_token if provided, and otherwise falls back to profile_name or the default credential chain.
Added regression coverage in test_ecstats.py (line 480) for both cases:
verifies direct access keys from config are forwarded into boto3.Session
verifies direct access keys take precedence over profile_name when both are configured
Validation:
./.env/bin/python -m pytest test_ecstats.py -q passed with 15 passed
Existing datetime.utcnow() deprecation warnings remain unchanged and are unrelated to this fix