ZXingScannerViewRenderer was causing the app to crash if the view was inside a ContentView#1060
Open
seansparkman wants to merge 1 commit intoRedth:masterfrom
Open
ZXingScannerViewRenderer was causing the app to crash if the view was inside a ContentView#1060seansparkman wants to merge 1 commit intoRedth:masterfrom
seansparkman wants to merge 1 commit intoRedth:masterfrom
Conversation
… inside a ContentView If the `ZXingScannerView` was inside of a `ContentView` instead of a `ContentPage`, the application would crash by throwing a `Java.Lang.NullPointerException`. The `Context` passed to `ZXingScannerViewRenderer` via the constructor was actually a `ContextThemeWrapper` which does not inherit from `Activity`. Therefore when it was cast in the call of the constructor of `ZXingScannerView` in the renderer on Android, a `null` would be passed for a context instead. Fixes: Redth#943
|
I experience a similar issue. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
ZXingScannerViewwas inside of aContentViewinstead of aContentPage, the application would crash by throwing aJava.Lang.NullPointerException. TheContextpassed toZXingScannerViewRenderervia the constructor was actually aContextThemeWrapperwhich does not inherit fromActivity. Therefore when it was cast in the call of the constructor ofZXingScannerViewin the renderer on Android, anullwould be passed for a context instead.Fixes: #943