fix: don't have overlapping jaccard similary matrix text#458
Merged
tristan-f-r merged 1 commit intoReed-CompBio:mainfrom Jan 21, 2026
Merged
fix: don't have overlapping jaccard similary matrix text#458tristan-f-r merged 1 commit intoReed-CompBio:mainfrom
tristan-f-r merged 1 commit intoReed-CompBio:mainfrom
Conversation
tristan-f-r
added
analysis
ntalluri
reviewed
Jan 21, 2026
Collaborator
ntalluri
left a comment
ntalluri
left a comment
There was a problem hiding this comment.
This looks good for now. I'm only concerned if we were to have a much larger matrix and still end up with overlapping numbers. Maybe instead of internalizing these changes, we can make these parameters available to the user to change what the output image looks like.
Collaborator
Author
|
I'll merge this for now, though I agree with that sentiment. There are other graphical analysis outputs that can also use manual adjustment when given larger amounts of data, and it will be hard to find when they'll fail every time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10 is notably a magic value.