Skip to content

Fix/oort 627 issue when inviting user#18

Open
AntoineRelief wants to merge 7 commits into
betafrom
fix/OORT-627-issue-when-inviting-user
Open

Fix/oort 627 issue when inviting user#18
AntoineRelief wants to merge 7 commits into
betafrom
fix/OORT-627-issue-when-inviting-user

Conversation

@AntoineRelief

Copy link
Copy Markdown
Collaborator

Description

Added a request to the server to check the status of the application before sending the invitations.
Edited the en.json and fr.json files to add the corresponding error messages.
Added a query to the server to get the status of the application.

Ticket

Ticket OORT-627
Previous pr

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tried to invite user when the application isn't published, got the error message showing
  • Couldn't test if the emails are sending or not because I don't have my .env file configured properly 😔

Sreenshots

image

Checklist:

( * == Mandatory )

  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

JulienKerlero and others added 7 commits May 29, 2023 16:59
of the application before sending the invitations.
Edited the en.json and fr.json files to add the
corresponding error messages.
Added a query to the server to get the status of
the application.
@AntoineRelief AntoineRelief added the enhancement New feature or request label Nov 27, 2023
@AntoineRelief AntoineRelief added the icebox On hold label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request icebox On hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants