test: add hover/focus parity tests for PrimaryButton (Closes #1433) - #1621
Open
waterWang wants to merge 2 commits into
Open
test: add hover/focus parity tests for PrimaryButton (Closes #1433)#1621waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
Closes Remitwise-Org#1421) Collapse the three identical Tailwind classnames helpers into a single canonical implementation in lib/utils/cn.ts. lib/utils.ts and lib/utils/index.ts now re-export from it instead of duplicating the same twMerge(clsx(...)) logic. Runtime behavior is unchanged; all cn-related tests pass.
…e-Org#1433) Add 17 tests covering: - Rendering with children (text and complex) - Default visual classes (layout, brand, sizing, transition) - Hover classes (hover:bg-brand.redHover) - Focus classes (focus:ring-2, focus:ring-brand.red) - Disabled state (disabled attribute, ARIA, click prevention) - Custom className merging with defaults - forwardRef support - HTML button attributes (type, aria-label, data-*) - Interaction parity: hover + focus coexistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comprehensive test suite for the
PrimaryButtoncomponent covering hover/focus parity and related behavior.What's covered (17 tests)
hover:bg-brand.redHoverpresentfocus:outline-none focus:ring-2 focus:ring-brand.red focus:ring-offset-2presentdisabledattribute,aria-disabled="true", click prevention, disabled visual classes<button>type,aria-label,data-*passthroughImplementation notes
components/ui/PrimaryButton.test.tsx(matches existing component test convention, e.g.ChipList.test.tsx,ShortcutTooltip.test.tsx).@testing-library/react+@testing-library/user-event, consistent with the rest of the repo.NODE_ENV=development(production React build rejectsact()).Closes #1433