refactor(remote-config): add RemoteConfigManager read facade (topic/body) by tonidero · Pull Request #3703 · RevenueCat/purchases-android

tonidero · 2026-07-02T14:15:14Z

Adds a read API to RemoteConfigManager so consumers can read remote-config data:

topic(name) — a topic's committed metadata.
blobData(topicName, itemKey) — a resolved item payload (its inline content, or its blob).

On a cache miss, a read resolves from an in-progress or on-demand sync instead of returning empty.

Note

Medium Risk
New suspend read paths can block on network and trigger on-demand /v1/config syncs; behavior is complex but heavily tested and gated on identity/disable state.

Overview
Adds a suspend read API on RemoteConfigManager: topic(RemoteConfigTopic) for committed item metadata, and blobData (transform + JSON reified) for blob-backed payloads. Reads run on IO, respect the session 4xx kill-switch (isUnavailable → isDisabled), and on a cache miss wait for an in-flight sync or trigger a foreground on-demand refresh when an app user ID is available (wired from PurchasesFactory via appUserIDProvider).

Introduces RemoteConfigTopic and threads it through RemoteConfigTopicStore / source parsing. Renames config item inline fields content → metadata and documents that payloads without blob_ref are index-only (blobData returns null).

syncAttributesAndOfferingsIfNeeded now calls refreshRemoteConfig before fetching offerings. Refresh completion is signaled with CompletableDeferred so blocked readers unblock on 204, errors, clearCache, and close. Unit, integration, and production golden tests cover the facade and waiting behavior.

^{Reviewed by Cursor Bugbot for commit e3f74fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

tonidero · 2026-07-02T14:15:29Z

refactor(remote-config): add RemoteConfigManager read facade (topic/body) #3703 : 2 dependent PRs (#3705 , #3708 ) 👈 (View in Graphite)
refactor(remote-config): Disable /v1/config for the session on a 4xx response #3700
refactor(remote-config): Re-arm blob sources only when exhausted + in-memory blob-store index #3698
refactor(remote-config): Wire the blob fetcher into RemoteConfigManager (prefetch, re-arm, clear) #3683
refactor(remote-config): Add RemoteConfigBlobFetcher #3679 : 1 other dependent PR (#3682 )
refactor(remote-config): user-scoped invalidation #3621
refactor(remote-config): persist the full topic index as the source of truth #3673
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2026-07-02T14:35:44Z

Codecov Report

❌ Patch coverage is 83.87097% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.59%. Comparing base (3183def) to head (e3f74fb).

Files with missing lines	Patch %	Lines
...rchases/common/remoteconfig/RemoteConfigManager.kt	84.31%	3 Missing and 5 partials ⚠️
.../com/revenuecat/purchases/PurchasesOrchestrator.kt	0.00%	0 Missing and 1 partial ⚠️
.../common/remoteconfig/RemoteConfigSourceProvider.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
+ Coverage   80.57%   80.59%   +0.02%     
==========================================
  Files         395      396       +1     
  Lines       16316    16366      +50     
  Branches     2322     2337      +15     
==========================================
+ Hits        13146    13190      +44     
- Misses       2243     2245       +2     
- Partials      927      931       +4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9d78258. Configure here.}

Adds suspend topic()/body() reads to RemoteConfigManager. On a cache miss, body() waits for an in-flight sync or triggers one on demand, unless the endpoint is disabled or no app user is known. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

topic()/body() and RemoteConfigTopicStore now take a closed RemoteConfigTopic (Workflows/UiConfig/Sources) instead of a raw topic string, so consumers can only read known topics. The disk cache stays string-keyed; the enum maps to its wire name at the store boundary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add two integration tests that read back through RemoteConfigManager's public topic()/body() facade after a sync persists to disk: - RemoteConfigManagerIntegrationTest: real disk cache + blob store, mocked backend; reads an inline-only item's topic and body off disk. - ProductionRemoteConfigIntegrationTest: real backend; a cold body() drives a genuine /v1/config fetch + persist, then reads an inlined workflows blob back off disk through the facade. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…gate reads when disabled Refines the read facade on the RemoteConfigManager: - Rename `body(topic, itemKey)` to `blobData`, with two overloads: a reified `blobData<T>` that parses the resolved blob as JSON into a `@Serializable` T via the shared JsonProvider, and a `blobData(..., transform)` overload for non-JSON blobs the caller decodes itself. - Drop the inline-content fallback: an item with no `blob_ref` now resolves to `null` (its inline data is exposed only through `topic()`), instead of returning the config JSON as a payload. - Rename `RemoteConfiguration.ConfigItem.content` to `metadata`. - Rename the session kill-switch `isUnavailable`/`unavailable` to `isDisabled`/`disabled`, and gate reads: `topic()` and `blobData()` return `null` once the endpoint is disabled (4xx), rather than serving cached data. - Refresh remote config as part of syncAttributesAndOfferingsIfNeeded. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…reads - PurchasesCommonTest: syncAttributesAndOfferingsIfNeeded triggers RemoteConfigManager.refreshRemoteConfig via the sync completion. - RemoteConfigManagerTest: reified blobData<T> fetches on demand then deserializes, matching the transform overload's wait/download path. - ProductionRemoteConfigIntegrationTest: end-to-end typed blobData<T> read of a workflows blob. Uses a minimal test-only type rather than PublishedWorkflow, which the shared defaultJson can't decode (polymorphic component tree) and which these lazy paywall workflows omit ui_config for. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Make RemoteConfigManager.topic() mirror blobData(): when no topic is committed yet, wait for an in-flight refresh (or trigger one on demand) and re-read before returning null, so a topic read during the initial sync returns fresh data instead of a spurious empty result. A committed topic still returns immediately, and a disabled endpoint or unknown user returns null with no network call. Simplify the integration tests to read topic() directly (the cold-load priming step is now redundant) and add unit coverage mirroring the blobData self-prime suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rickvdl

Awesome work! Couple of notes / questions

rickvdl · 2026-07-03T11:42:25Z

+    suspend inline fun <reified T> blobData(topic: RemoteConfigTopic, itemKey: String): T? =
+        blobData(topic, itemKey) { bytes ->
+            try {
+                JsonProvider.defaultJson.decodeFromString<T>(bytes.decodeToString())


I think this is what you meant over slack; but decoding errors are now also returned as null (which is expected in it's current state), but indeed maybe some typed errors would be nice

Right, in the end I guess it depends on the consumers and whether and how we want to expose this later on. We already log these internally, so a consumer of this API right now can only know that something went wrong, but not what... So yeah, adding a better response might make more sense, but might leave that for a separate PR and also see if consumers do actually need that info.

rickvdl

Awesome work! Almost there 💪

This was referenced Jul 2, 2026

refactor(remote-config): Disable /v1/config for the session on a 4xx response #3700

Merged

refactor(remote-config): Wire the blob fetcher into RemoteConfigManager (prefetch, re-arm, clear) #3683

Merged

tonidero mentioned this pull request Jul 2, 2026

refactor(remote-config): Re-arm blob sources only when exhausted + in-memory blob-store index #3698

Merged

tonidero added feat:remote-config pr:other labels Jul 2, 2026

tonidero changed the title ~~feat(remote-config): add RemoteConfigManager read facade (topic/body)~~ refactor(remote-config): add RemoteConfigManager read facade (topic/body) Jul 2, 2026

tonidero marked this pull request as ready for review July 2, 2026 15:41

tonidero requested a review from a team as a code owner July 2, 2026 15:41

tonidero force-pushed the phase_6_read_facade_topic_body branch from 57d60c2 to 9d78258 Compare July 3, 2026 07:47

tonidero force-pushed the disable_remote_config_on_4xx branch from 5659295 to 8cfe71a Compare July 3, 2026 07:47

tonidero mentioned this pull request Jul 3, 2026

refactor(remote-config): Disable in CEC mode + add observability logs #3705

Merged

cursor Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread purchases/src/main/kotlin/com/revenuecat/purchases/common/remoteconfig/RemoteConfigManager.kt

Base automatically changed from disable_remote_config_on_4xx to main July 3, 2026 09:13

tonidero force-pushed the phase_6_read_facade_topic_body branch from 9d78258 to 0932eb0 Compare July 3, 2026 09:39

tonidero and others added 8 commits July 3, 2026 13:03

Remove comment

c570c4b

Add golden files for new test

2f681b3

tonidero force-pushed the phase_6_read_facade_topic_body branch from ee90f08 to 3553a9b Compare July 3, 2026 11:03

This was referenced Jul 3, 2026

refactor(workflows): serve workflows and ui_config from the config endpoint #3708

Closed

Fall back to the offerings paywall when the workflow fetch fails #3709

Open

refactor(workflows): give ui_config its own independent read path #3710

Closed

rickvdl reviewed Jul 3, 2026

View reviewed changes

rickvdl mentioned this pull request Jul 3, 2026

feat(remote-config): add APIs for reading topic/blob data from RemoteConfigManager RevenueCat/purchases-ios#7134

Merged

tonidero added 2 commits July 3, 2026 15:22

Update golden file

f75a8d8

Make close more robust

e3f74fb

rickvdl approved these changes Jul 3, 2026

View reviewed changes

tonidero added this pull request to the merge queue Jul 3, 2026

Merged via the queue into main with commit 2710b6f Jul 3, 2026
37 checks passed

tonidero deleted the phase_6_read_facade_topic_body branch July 3, 2026 14:43

tonidero mentioned this pull request Jul 3, 2026

fix(remote-config): Remote-config fixes/improvements #3714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(remote-config): add RemoteConfigManager read facade (topic/body)#3703

refactor(remote-config): add RemoteConfigManager read facade (topic/body)#3703
tonidero merged 10 commits into
mainfrom
phase_6_read_facade_topic_body

tonidero commented Jul 2, 2026 •

edited by cursor Bot

Loading

Uh oh!

tonidero commented Jul 2, 2026 •

edited by vegaro

Loading

Uh oh!

codecov Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

rickvdl left a comment

Uh oh!

Uh oh!

Uh oh!

rickvdl Jul 3, 2026

Uh oh!

tonidero Jul 3, 2026

Uh oh!

Uh oh!

rickvdl left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tonidero commented Jul 2, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonidero commented Jul 2, 2026 • edited by vegaro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rickvdl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rickvdl Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

tonidero Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rickvdl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tonidero commented Jul 2, 2026 •

edited by cursor Bot

Loading

tonidero commented Jul 2, 2026 •

edited by vegaro

Loading

codecov Bot commented Jul 2, 2026 •

edited

Loading