[WIP] - Fix ebs__download_snapshots region issue #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnap’s init sees that region is provided and creates a boto3 session with that region (e.g., "us-west-2"). This ensures that all subsequent API calls—like list_snapshot_blocks—are directed to the correct AWS region where the snapshot exists. In summary, this fix decouples the region from the potentially misconfigured Pacu session and guarantees that dsnap is querying AWS in the intended region.
fix trailing whitespace
Contributor
Author
|
I believe the errors from the build process are due to it relying on the old version of dsnap; the dsnap PR will need to be approved first |
DaveYesland
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Pacu module for downloading EBS snapshots to explicitly pass the region to dsnap’s
LocalSnapshotconstructor. By doing so, dsnap is forced to create its boto3 session using the correct AWS region (e.g., "us-west-2"), rather than defaulting to "us-east-1". This prevents errors likeResourceNotFoundExceptionwhen the snapshot exists in a non-default region.Important
The Dsnap PR needs to also be approved for this to work properly - RhinoSecurityLabs/dsnap#29