libgstd: fix race conditions in pipeline list and session property access#342
Open
rwang-mtdata wants to merge 5 commits into
Open
libgstd: fix race conditions in pipeline list and session property access#342rwang-mtdata wants to merge 5 commits into
rwang-mtdata wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread-safety fixes for concurrent gstd clients accessing pipelines and session
properties. Addresses several races and a use-after-free observed under load.
Changes
gstd_list: count pipelines under lock at point-of-use; lock shared linked access.gstd_list_reader/gstd_parser/gstd_pipeline:find_childnow returns anowned reference, fixing a use-after-free when the child is removed concurrently.
gstd_session: lockPROP_PIPELINES/PROP_DEBUGaccessors; unref the oldvalue when swapping.
Files changed
libgstd/gstd_list.c, gstd_list.h, gstd_list_reader.c, gstd_parser.c,
gstd_pipeline.c, gstd_session.c (+116 / -55)
Testing
upstream/develop(rebased onto e95cd75).Risk