Eliminate gray border in ToGdipBitmap#133
Open
viskin wants to merge 1 commit intoRobmaister:masterfrom
Open
Conversation
Contributor
|
I agree that the rendered image looks wrong - but I wonder if this should be reported upstream? (sorry, used the wrong account). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of ToGdipBitmap extension method (when PixelMode.Gray) keeps gray border around letters:
It doesn't look good when bright text is rendered on bright background.
Instead, I propose to eliminate this background and use only alpha component for antialiasing.
The PR produces following text:
Black text on white background produces same pixels when the PR applied.