feat(rollout): forward --sglang-text-encoder-precisions to the engine - #4
Closed
Rockdu wants to merge 1 commit into
Closed
feat(rollout): forward --sglang-text-encoder-precisions to the engine#4Rockdu wants to merge 1 commit into
Rockdu wants to merge 1 commit into
Conversation
Owner
Author
|
Moved to radixark — a PR inside the fork is not reviewable there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Forward
--sglang-text-encoder-precisionsfrom miles to the rollout engine.Why
text_encoder_precisionsis aPipelineConfigfield, so miles' auto-prefix already exposes--sglang-text-encoder-precisionson the CLI, but_compute_server_argsonly forwardsdit_precision/vae_precisionexplicitly. Passing the flag today is silently dropped and the engine keeps its per-pipeline defaults. This bites whenever the DiT precision is moved off the pipeline default: SD3 ships("fp16", "fp16", "fp32")text encoders, so an fp32 DiT run dies in the engine withmat1 and mat2 must have the same dtypeuntil the encoders follow.set_defaults(..., None)keeps "unset" detectable, so a run that does not pass the flag forwards nothing and the engine's own defaults still win.Files
miles/utils/arguments.py— default the passthrough arg to Nonemiles/backends/sglang_diffusion_utils/sglang_diffusion_engine.py— add the field to the explicit forwarding tupleChecklist
pre-commit run --all-files— not run locallypytest -x— not run locallypython3 train_diffusion.py --helpparses, and an SD3 GRPO run launches with the flag set (verified on an H200 devbox)