fix: prevent attachment metadata text overlap on mobile view#1121
Open
Khizarshah01 wants to merge 1 commit intoRocketChat:developfrom
Open
fix: prevent attachment metadata text overlap on mobile view#1121Khizarshah01 wants to merge 1 commit intoRocketChat:developfrom
Khizarshah01 wants to merge 1 commit intoRocketChat:developfrom
Conversation
Contributor
Author
|
Hi @Spiral-Memory , Could you please review this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attachment metadata text (title and file size) overlaps on mobile view due to inheriting
line-height: 0from parent attachment containers.Fix
Explicitly set a readable
line-heightfor attachment metadata text to ensure proper vertical stacking on mobile layouts across all attachment types.Testing
Before
After