Adiciona script para configuração inicial do template, esse script re…#8
Open
guimulu wants to merge 1 commit intoRocketseat:masterfrom
Open
Adiciona script para configuração inicial do template, esse script re…#8guimulu wants to merge 1 commit intoRocketseat:masterfrom
guimulu wants to merge 1 commit intoRocketseat:masterfrom
Conversation
…move arquivos e pastas que não usamos e automatiza a configuração adicional do Android
| `android/app/src/main/java/com/${name.toLowerCase()}/MainActivity.java`, | ||
| ); | ||
|
|
||
| console.log('\n 📝 Adicionando configurações no arquivo MainActivity.java'); |
Contributor
There was a problem hiding this comment.
Por que essa etapa é necessária?
Author
There was a problem hiding this comment.
Se está se referindo a linha 28, serve para pegar o caminho absoluto do arquivo MainActivity.java. Tem algo de errado ou a melhorar?
Contributor
There was a problem hiding this comment.
Não, estava me referindo mesmo ao processo de injetar todo esse código na Activity. Mudou algo que tornou isso necessário?
Author
There was a problem hiding this comment.
Sim, a adição das configurações (imports e métodos) para o correto funcionamento da lib de gestos no android.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Adiciona script para configuração inicial do template, esse script remove arquivos e pastas que não usamos e automatiza a configuração adicional do Android.
Me basei no script do @lucianomlima , muito obrigado.
Se for aprovado, posso adicionar no template advanced também.