fix: Correctly pass value of WingetSourceCustom, Fixes #1043#1135
Open
Salamek wants to merge 3 commits intoRomanitho:developfrom
Open
fix: Correctly pass value of WingetSourceCustom, Fixes #1043#1135Salamek wants to merge 3 commits intoRomanitho:developfrom
Salamek wants to merge 3 commits intoRomanitho:developfrom
Conversation
required functions and replace hardoded -s 'winget' with -s $src
Owner
|
Hi, thanks for your contribution! Regarding |
for backward compatibility
Author
|
Ok i have added -Source parameter to Winget-Install that defaults to 'winget' when not provided |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly pass value of WingetSourceCustom, to required functions and replace hardcoded -s 'winget' with -s $src
Proposed Changes
WAU allows to set WAU_WingetSourceCustom registry key to specify what repository should WAU work with, but this key value is used only in few places, in rest it was hardcoded to 'winget' making autoupdates impossible
Note: I did not change hardcoded stuff in Winget-Install.ps1 since header says "Deprecated in favor of Winget-AutoUpdate." so i assume it is not needed there
Related Issues
#1043