feat(#616): add Node 26 to CI matrices - #644
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Node.js 26 coverage to the project’s GitHub Actions CI matrices and introduces an npm overrides entry to keep the Node 26 test/coverage toolchain working (via forcing yargs to a Node-26-compatible version for c8’s dependency tree).
Changes:
- Expanded the Node version matrix to include Node 26 in both test and publish workflows.
- Added an npm
overridesrule foryargs(and updated the lockfile accordingly) to unblockc8on Node 26.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Adds overrides to force yargs v18 to keep c8 working on Node 26. |
package-lock.json |
Updates resolved dependency graph to reflect the yargs override (including transitive updates). |
.github/workflows/npm-test.yml |
Adds Node 26 to the CI test matrix. |
.github/workflows/npm-publish.yml |
Adds Node 26 to the release build/test matrix prior to publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #616
Changes
npm-test.ymlandnpm-publish.yml"overrides": { "yargs": "^18.0.0" }topackage.jsonto unblockc8on Node 26Context
c8bundlesyargs@17.7.2which has"type": "module"but its./yargsentrypoint usesrequire(). Node 26's now-stablerequire()-of-ESM feature properly loads it as ESM, causingrequire()inside the file to fail. Overridingyargsto^18.0.0resolves this.The upstream fix is tracked in bcoe/c8#578. Once it ships, the override can be removed — tracked in #643.
Verified on Node 26
All scripts pass clean on Node 26:
npm run lint✅npm test✅npm run test:coverage✅npm run build✅npm run smoke✅