Added message board details with rspec#5
Open
mikeadeleke wants to merge 1 commit intoRubyoffRails:masterfrom
mikeadeleke:master
Open
Added message board details with rspec#5mikeadeleke wants to merge 1 commit intoRubyoffRails:masterfrom mikeadeleke:master
mikeadeleke wants to merge 1 commit intoRubyoffRails:masterfrom
mikeadeleke:master
Conversation
Member
There was a problem hiding this comment.
Here you left the existing def initialize(engineer)
The class works, but only because Ruby is a "last method defined wins" --- you should remove the older initiation and engineer.slow_down!
Member
|
You did a great job of adding in the message_board. The idea was to replace the engineer with the message_board. Then, the message_board could notify multiple things (like the engineer, and the news, and twitter :) ) |
Author
|
Haha okay. I gotcha now. I think Twitter would probably be the most critical :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.