Refactor Configuration Properties #318
Conversation
This commit centralizes all configuration properties supported by the extension. It also introduces new property names to align with other agent extensions used in SAP BTP. Signed-off-by: Karsten Schnitter <[email protected]>
FWinkler79
left a comment
FWinkler79
left a comment
There was a problem hiding this comment.
Thanks Karsten,
generally looks good. I just noticed one setting that we had named slightly differently.
The setting is sap.dynatrace.cf.binding.token.name which in your version still includes a metric in the name. Not sure you need it or if it is a mistake.
If you still need it, please let me know, and I will update our document accordingly.
| | `sap.cloud-logging.cf.binding.tag.value` | `Cloud Logging` | The tag of any service binding (managed or user-provided) to bind to. | | ||
| | `sap.dynatrace.cf.binding.label.value` | `dynatrace` | The label of the managed service binding to bind to. | | ||
| | `sap.dynatrace.cf.binding.tag.value` | `dynatrace` | The tag of any service binding (managed or user-provided) to bind to. | | ||
| | `sap.dynatrace.cf.binding.metrics.token.name` | | The name of the field containing the Dynatrace API token within the service binding credentials. This is required to send metrics to Dynatrace. | |
There was a problem hiding this comment.
In the document we had called this sap.dynatrace.cf.binding.token.name (without metrics in between).
| | `sap.dynatrace.cf.binding.tag.value` | `dynatrace` | The tag of any service binding (managed or user-provided) to bind to. | | ||
| | `sap.dynatrace.cf.binding.metrics.token.name` | | The name of the field containing the Dynatrace API token within the service binding credentials. This is required to send metrics to Dynatrace. | | ||
| | `sap.cloudfoundry.otel.resources.enabled` | `true` | Whether to add CF resource attributes to all events. | | ||
| | `sap.cloudfoundry.otel.resources.format` | `SAP` | The semantic convention to follow for the CF resource attributes. | |
There was a problem hiding this comment.
Not naming-related, but maybe you want to specify here what are the possible values (e.g. sap or otel).
| ```sh | ||
| java #... \ | ||
| -Dotel.javaagent.extension.sap.cf.binding.dynatrace.metrics.token-name=<your_token_field> \ | ||
| -Dsap.dynatrace.cf.binding.metrics.token.name=<your_token_field> \ |
There was a problem hiding this comment.
see also here: This still has metrics in the name. In our document we had removed that.
Removes `metrics` from Dynatrace token name config. Adds options for resource format. Signed-off-by: Karsten Schnitter <[email protected]>
|
@FWinkler79 thanks for the review. I have addressed all your comments. The |
This commit centralizes all configuration properties supported by the extension. It also introduces new property names to align with other agent extensions used in SAP BTP.