-
-
Notifications
You must be signed in to change notification settings - Fork 341
Update more copyright sections of files to current standard. #4808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/generated/examples/commandline_Variables_custom_py_1_custom.py
Outdated
Show resolved
Hide resolved
mwichmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly this is good, but seems like a few places dropped comments we might want to keep, and a few changed the short form header to the long one including the license text. I didn't pay as much attention to stuff we don't actually use, like doc/{design,developer,reference,python10} and timings. Well, I've poked at the latter occasionally, so it's not completely unused, but I think most of those don't work now.
fc0462d to
64736e6
Compare
|
reverted several commits as there was a glitch in updating copyright in xml/xsl files. I'll do those in a separate PR |
| @@ -1,3 +1,4 @@ | |||
| # | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this extra blank comment line should br dropped.
| cases that people supply (typically in a .zip or .tar.gz file) into a | ||
| TestSCons.py script. No error checking or options yet, it just walks | ||
| the first command-line argument (assumed to be the directory containing | ||
| the test case) and spits out code looking like the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use double colon to introduce code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| SPDX-FileType: DOCUMENTATION | ||
| -->""" | ||
|
|
||
| def update_xml_file(file_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to assume this is all okay without reviewing in any detail....
doc/sphinx/conf.py
Outdated
| # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
|
|
||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave this one as it was originally, exactly the comment created by the tool. We'll probably rerun the tool someday as there are many new settings in Sphinx, and that will make it easier to diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
|
Looks good now - just a few comments. |
|
Merging. |
More updates
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).