Skip to content

Conversation

@bdbaddog
Copy link
Contributor

@bdbaddog bdbaddog commented Jan 1, 2026

More updates

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@bdbaddog bdbaddog changed the title Update tests file headers Update more copyright sections of files to current standard. Jan 1, 2026
@bdbaddog bdbaddog requested a review from mwichmann January 1, 2026 02:32
@mwichmann mwichmann added the maintenance Tasks to maintain internal SCons code/tools label Jan 1, 2026
@mwichmann mwichmann moved this to In review in Next Release Jan 1, 2026
Copy link
Collaborator

@mwichmann mwichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly this is good, but seems like a few places dropped comments we might want to keep, and a few changed the short form header to the long one including the license text. I didn't pay as much attention to stuff we don't actually use, like doc/{design,developer,reference,python10} and timings. Well, I've poked at the latter occasionally, so it's not completely unused, but I think most of those don't work now.

@bdbaddog bdbaddog force-pushed the update_tests_file_headers branch from fc0462d to 64736e6 Compare January 2, 2026 02:02
@bdbaddog
Copy link
Contributor Author

bdbaddog commented Jan 2, 2026

reverted several commits as there was a glitch in updating copyright in xml/xsl files.
And force pushed.

I'll do those in a separate PR

@@ -1,3 +1,4 @@
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this extra blank comment line should br dropped.

cases that people supply (typically in a .zip or .tar.gz file) into a
TestSCons.py script. No error checking or options yet, it just walks
the first command-line argument (assumed to be the directory containing
the test case) and spits out code looking like the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use double colon to introduce code block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

SPDX-FileType: DOCUMENTATION
-->"""

def update_xml_file(file_path):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume this is all okay without reviewing in any detail....

# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.


"""
Copy link
Collaborator

@mwichmann mwichmann Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave this one as it was originally, exactly the comment created by the tool. We'll probably rerun the tool someday as there are many new settings in Sphinx, and that will make it easier to diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@mwichmann
Copy link
Collaborator

Looks good now - just a few comments.

@bdbaddog
Copy link
Contributor Author

bdbaddog commented Jan 4, 2026

Merging.

@bdbaddog bdbaddog merged commit e158996 into SCons:master Jan 4, 2026
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Next Release Jan 4, 2026
@mwichmann mwichmann added this to the NextRelease milestone Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Tasks to maintain internal SCons code/tools

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants