Skip to content

Run bundle after reissue:bump updates the version#108

Merged
saturnflyer merged 1 commit intomainfrom
fix/bump-task-runs-bundle
Feb 24, 2026
Merged

Run bundle after reissue:bump updates the version#108
saturnflyer merged 1 commit intomainfrom
fix/bump-task-runs-bundle

Conversation

@saturnflyer
Copy link
Member

Summary

  • Calls bundle after reissue:bump updates the version file, matching the behavior of the main reissue task
  • Adds 3 regression tests verifying bundle is called (or not) after bump

Problem

When reissue:bump changes version.rb (e.g. from 2.1.14 to 3.0.0), the Gemfile.lock becomes stale because it still references the old gemspec version. The subsequent rake release then fails at release:guard_clean because there are uncommitted changes to the lockfile.

This was hit in SOFware/circulator's release workflow:

Version bumped (major) to 3.0.0
circulator 2.1.14 built to pkg/circulator-3.0.0.gem.
There are files that need to be committed first.
Tasks: TOP => release => release:guard_clean

The main reissue task already calls bundle after updating the version — reissue:bump was missing the same call.

Test plan

  • 3 new tests added:
    • test_bump_calls_bundle_when_tag_matches_current_version — standard bump path
    • test_bump_calls_bundle_when_version_differs_from_tag — post-release bump path (the exact failure scenario)
    • test_bump_does_not_call_bundle_when_no_version_trailer — no unnecessary calls
  • Full test suite passes (129 tests, 368 assertions)

@saturnflyer saturnflyer requested a review from a team as a code owner February 24, 2026 16:45
The reissue:bump task updates version.rb but did not re-run
bundle install afterwards. When a gem's gemspec reads its
version from version.rb, the Gemfile.lock becomes stale after
the bump. This causes release:guard_clean to fail because the
lockfile no longer matches the gemspec version.

The main reissue task already calls bundle after updating the
version. This applies the same pattern to reissue:bump.

Fixed: Run bundle install after reissue:bump changes the version
@saturnflyer saturnflyer force-pushed the fix/bump-task-runs-bundle branch from f559d0e to 104bfd8 Compare February 24, 2026 16:48
@saturnflyer saturnflyer merged commit 9abd75c into main Feb 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants