Run bundle after reissue:bump updates the version#108
Merged
saturnflyer merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
The reissue:bump task updates version.rb but did not re-run bundle install afterwards. When a gem's gemspec reads its version from version.rb, the Gemfile.lock becomes stale after the bump. This causes release:guard_clean to fail because the lockfile no longer matches the gemspec version. The main reissue task already calls bundle after updating the version. This applies the same pattern to reissue:bump. Fixed: Run bundle install after reissue:bump changes the version
f559d0e to
104bfd8
Compare
rbazinet
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundleafterreissue:bumpupdates the version file, matching the behavior of the mainreissuetaskProblem
When
reissue:bumpchangesversion.rb(e.g. from2.1.14to3.0.0), theGemfile.lockbecomes stale because it still references the old gemspec version. The subsequentrake releasethen fails atrelease:guard_cleanbecause there are uncommitted changes to the lockfile.This was hit in SOFware/circulator's release workflow:
The main
reissuetask already callsbundleafter updating the version —reissue:bumpwas missing the same call.Test plan
test_bump_calls_bundle_when_tag_matches_current_version— standard bump pathtest_bump_calls_bundle_when_version_differs_from_tag— post-release bump path (the exact failure scenario)test_bump_does_not_call_bundle_when_no_version_trailer— no unnecessary calls