Forward tag_pattern through call and finalize paths#110
Merged
saturnflyer merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
The tag_pattern configured on Reissue::Task was only forwarded to the git fragment handler in the preview and bump tasks. The main reissue (version bump) and reissue:finalize tasks did not pass it through Reissue.call, Reissue.finalize, or ChangelogUpdater, so the handler always fell back to the default pattern (/^v(\d+\.\d+\.\d+.*)$/). For projects using non-semver tag formats (e.g. v2026.02.A), this caused the handler to match zero tags, fall back to scanning all commits, and carry every historical trailer into the new version entry instead of starting clean. Thread tag_pattern: nil through Reissue.call, Reissue.finalize, ChangelogUpdater#call, and ChangelogUpdater#update so it reaches FragmentHandler.for in every code path. Fixed: Forward tag_pattern to git fragment handler in call and finalize
jeffdlange
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tag_pattern:throughReissue.call,Reissue.finalize,ChangelogUpdater#call, andChangelogUpdater#updateso it reachesFragmentHandler.forin every code pathreissue(bump) andreissue:finalizerake tasks now forwardtag_pattern:to the formattertag_patternwas only forwarded in thepreviewandbumptasks, causing the git fragment handler to fall back to the default semver pattern in the main release workflowRoot cause: For projects using non-semver tags (e.g.
v2026.02.A), the default pattern (/^v(\d+\.\d+\.\d+.*)$/) matched zero tags. This caused the handler to scan all commits in history and carry every historical trailer into the new version entry instead of starting clean.Test plan
test_changelog_updater.rb(update and call)test_reissue.rb(Reissue.call and Reissue.finalize)