Thread tag_pattern through call and finalize chains#111
Closed
jeffdlange wants to merge 1 commit intomainfrom
Closed
Thread tag_pattern through call and finalize chains#111jeffdlange wants to merge 1 commit intomainfrom
jeffdlange wants to merge 1 commit intomainfrom
Conversation
The tag_pattern configured on the Rake task was only passed to the preview and bump tasks, but not to the core call() and finalize() methods. This meant the git fragment handler always used its default pattern (/^v(\d+\.\d+\.\d+.*)$/), which fails to match custom tag formats like v2026.02.A. Without finding matching tags, the handler reads ALL git trailers from the entire repository history instead of just since the last release, causing the new version to inherit all previous entries. Also passes retain_changelogs to formatter.call() from the reissue rake task, which was previously defaulting to false. Fixed: tag_pattern not threaded through to call and finalize
Author
|
Obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tag_patternconfigured onReissue::Taskwas only forwarded to thepreviewandbumptasks, but not to the coreReissue.call()andReissue.finalize()methodsGitFragmentHandlerto always use its default pattern (/^v(\d+\.\d+\.\d+.*)$/), which fails for custom tag formats (e.g.,v2026.02.A)retain_changelogstoformatter.call()from the reissue rake task (was defaulting tofalse)Changes
Threads
tag_pattern:through:rake.rb— passestag_pattern:andretain_changelogs:toformatter.call()andformatter.finalize()reissue.rb— acceptstag_pattern:incall()andfinalize(), forwards toFragmentHandler.for()changelog_updater.rb— acceptstag_pattern:incall()andupdate(), forwards toFragmentHandler.for()Test plan
tag_patternthatreissue:finalizeandreissuecorrectly scope git trailers to commits since the last matching tag