feat(packages/sui-segment-wrapper): remove manual ga4 implementation#1984
Merged
Conversation
BREAKING CHANGES: ga4 web mode destinations needs to be used on segment
…gration with automatic destinat
tomasmax
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add backwards-compatible GA4 integration with automatic mode detection and remove deprecated Adobe Analytics integration.
Changes
Backwards-Compatible GA4 Dual-Mode Integration
Added automatic mode detection to support both manual GA4 initialization (existing) and Segment GA4 destination (new):
LEGACY Mode (when
googleAnalyticsMeasurementIdis configured):'Google Analytics 4'withclientIdandsessionIdobjectgoogle_consentssent incontextanalytics_storageincluded incontextloadGoogleAnalytics(),getGoogleClientId(),getGoogleSessionId()triggerGoogleAnalyticsInitEvent(),setGoogleUserId()sendGoogleConsents()for GTM Consent ModegetCampaignDetails()NEW Mode (when
googleAnalyticsMeasurementIdis NOT configured):'Google Analytics 4 Web': truegoogle_consentssent inproperties(Segment best practice)analytics_storagein context (handled by destination)Detection Logic:
!getConfig('googleAnalyticsMeasurementId')src/utils/ga4Detection.jsKey Fixes:
integrationsnow sent in both main object ANDcontext.integrations(fixed integration routing)google_consentslocation optimized based on mode:contextfor LEGACY,propertiesfor NEWAdobe Analytics Removal
Removed deprecated Adobe Analytics integration (no longer used):