Skip to content

varbin: Fix handle private field by accident #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xchacha20-poly1305 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

varbin: Fix handle private field by accident #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/varbin/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func read(r Reader, order binary.ByteOrder, data reflect.Value, isArrayMapValue
for i := 0; i < fieldLen; i++ {
field := data.Field(i)
fieldName := fieldType.Field(i).Name
if field.CanSet() || fieldName != "_" {
if field.CanSet() {
err := read(r, order, field, false)
if err != nil {
return E.Cause(err, fieldName)
Expand Down Expand Up @@ -364,7 +364,7 @@ func write(writer Writer, order binary.ByteOrder, data reflect.Value, isArrayOrM
for i := 0; i < fieldLen; i++ {
field := data.Field(i)
fieldName := fieldType.Field(i).Name
if field.CanSet() || fieldName != "_" {
if field.CanSet() {
err := write(writer, order, field, false)
if err != nil {
return E.Cause(err, fieldName)
Expand Down
Loading