fix: Scheduled autotitling can overwrite concurrent session metadata - #982
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: Scheduled autotitling can overwrite concurrent session metadata#982sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
UpdateGeneratedTitleand neverUpdatewhen the store supports the title-only capability.Why this is high-value
The autotitle command loads all candidate sessions before making serial provider calls, so a later candidate can be stale for minutes. A full-row
Updatefrom that snapshot could silently revert user-visible changes made while the job was running, including a manual title, pin/status state, model selection, and goal. The title-only update removes that realistic race without changing title generation behavior.Validation
gofmt -w cmd/sessions_autotitle.go cmd/sessions_autotitle_test.gogo build ./...go test ./cmd -run '^TestUpdateAutotitleDoesNotClobberConcurrentSessionMetadata$' -count=1go test ./...with an isolatedHOME/XDG_CONFIG_HOME(passes; the normal agent home injects its global skill catalog into two unrelated cwd-skill tests)git diff --check