fix: Slow side-question SSE clients can strand provider runs indefinitely - #984
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: Slow side-question SSE clients can strand provider runs indefinitely#984sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this is high-value
The HTTP server intentionally has no global write timeout so long-lived SSE streams remain valid. Previously, side-question SSE was the exception to the per-write deadline rule: a suspended mobile browser or another client that stopped reading could block the handler in
WriteorFlushforever. Because the provider uses a detached context, that also left the side question active, made the session non-evictable, and caused later side questions to conflict. Bounding each write lets the existing write-error path cancel the provider and release the session.Validation
gofmt -w cmd/serve_side_question.go cmd/serve_side_question_test.gogo build ./...XDG_CONFIG_HOME=$(mktemp -d) go test ./...go test ./cmd -run 'TestServeSideQuestion(Disconnect|SlowClient)' -count=100git diff --check