Skip to content

feat: expand visual workflow coverage and theme validation#176

Merged
SamXop123 merged 1 commit into
SamXop123:mainfrom
vraj826:test/expand-renderer-coverage
Jun 11, 2026
Merged

feat: expand visual workflow coverage and theme validation#176
SamXop123 merged 1 commit into
SamXop123:mainfrom
vraj826:test/expand-renderer-coverage

Conversation

@vraj826

@vraj826 vraj826 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Expanded renderer snapshot coverage and added theme contract validation to improve confidence in SVG rendering behavior across supported layouts and themes.

Related Issue

Closes #172

Type of Change

  • Refactor

Changes Made

  • Expanded visual-workflow.test.js snapshot coverage for:

    • hidden trophies
    • no CP platform
    • single CP platform
    • multiple CP platforms
    • graceful fallback rendering
  • Added lightweight SVG validity assertions for generated output

  • Added theme contract validation to verify:

    • required color fields
    • chart color definitions
    • expected theme object structure
  • Updated existing snapshots using the current test infrastructure

  • Added missing contract color aliases to:

    • cobalt2
    • one-dark
    • github-light

Testing

  • Ran npm test — all tests pass
  • Tested manually (if applicable)

Verification performed:

  • npm.cmd run test:visual -- --updateSnapshot → passing
  • npm.cmd test → passing (12 suites, 172 tests, 28 snapshots)

Screenshots (if applicable)

N/A

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation if necessary
  • My changes are scoped to a single issue

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

@vraj826 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vraj826

vraj826 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@SamXop123 Can you review the changes!

@SamXop123 SamXop123 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @vraj826

@SamXop123 SamXop123 merged commit 4e1bfba into SamXop123:main Jun 11, 2026
2 of 3 checks passed
@github-actions

Copy link
Copy Markdown

🎉 Congratulations @vraj826! 🎉

Your pull request has been successfully merged into samdev-pulse! Thank you so much for your valuable contribution and effort. Every single improvement helps make samdev-pulse a better profile experience for everyone! 🙌

🚀 What's Next?

  • Keep the momentum going! Feel free to browse through our open Issues and grab another one that interests you!
  • Support the Project: If you enjoyed contributing to samdev-pulse, please take a second to star our repository! It helps increase the project's visibility and supports our community. ⭐

💬 Stay Connected:
Have any questions, want feedback, or just want to discuss further contributions? Feel free to reach out directly to the maintainer on Discord: dot_notsam!

Thank you again, and keep up the amazing work! 💻✨

@vraj826 vraj826 deleted the test/expand-renderer-coverage branch June 11, 2026 16:02
@vraj826

vraj826 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Excellent work @vraj826

Thank you @SamXop123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add SVG Renderer Snapshot Tests and Theme Contract Validation

2 participants