feat: expand visual workflow coverage and theme validation#176
Merged
Conversation
|
@vraj826 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@SamXop123 Can you review the changes! |
SamXop123
approved these changes
Jun 11, 2026
|
🎉 Congratulations @vraj826! 🎉 Your pull request has been successfully merged into samdev-pulse! Thank you so much for your valuable contribution and effort. Every single improvement helps make samdev-pulse a better profile experience for everyone! 🙌 🚀 What's Next?
💬 Stay Connected: Thank you again, and keep up the amazing work! 💻✨ |
Contributor
Author
Thank you @SamXop123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expanded renderer snapshot coverage and added theme contract validation to improve confidence in SVG rendering behavior across supported layouts and themes.
Related Issue
Closes #172
Type of Change
Changes Made
Expanded
visual-workflow.test.jssnapshot coverage for:Added lightweight SVG validity assertions for generated output
Added theme contract validation to verify:
Updated existing snapshots using the current test infrastructure
Added missing contract color aliases to:
cobalt2one-darkgithub-lightTesting
npm test— all tests passVerification performed:
npm.cmd run test:visual -- --updateSnapshot→ passingnpm.cmd test→ passing (12 suites, 172 tests, 28 snapshots)Screenshots (if applicable)
N/A
Checklist