Remove QtWebEngine and replace with system browser#3847
Remove QtWebEngine and replace with system browser#3847
Conversation
|
Will this get us to only needing PySide6-Essentials as a (build)dependency? (no need for PySide6-Addons)? Some quick grepping makes me think you might have already got there. That would be fantastic. |
|
There's still one remaining Addons dependency: from PySide6.QtDataVisualization import Q3DScatter, QScatter3DSeries, QScatterDataItem, QValue3DAxisWe need it for the Shape2SAS 3D scatter plot viewer. Replacing it with something from Essentials (e.g., matplotlib 3D plots or a custom implementation) to fully drop the Addons dependency. |
|
This PR can go |
QtDataVisualization is actually deprecated. iirc it caused some issues with the Flatpak, although I don't remember how it was resolved. According to the QT documentation, we're supposed to use QT Graphs instead. |
|
@rozyczko to take another look at this. |
| self.hs.show_help(str(absolute_url)) | ||
|
|
||
| opened_url = mock_wb.open.call_args[0][0] | ||
| assert opened_url == ( |
There was a problem hiding this comment.
This assert is failing on Ubuntu and MacOS, but succeeding for Windows. Somehow tmp_path is not empty.
Side note: The url for previous docs starts with https://www.sasview.org/docs/old_docs/<ver>/. The URL you are using will resolve, but as a 404 page.
|
Closing with #3923 being the replacement. |
4 participants
Description
This is a preliminary version of the QtWebEngine-less SasView.
All calls have been converted to consistent system browser calls.
References to QtWebEngine were removed.
Tests updated (although we don't run these tests, anyway)
Fixes #3511
How Has This Been Tested?
Locally on Win11
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)