[COD-53] Verify complete flow and add missing parts#57
Conversation
…ked courses spec [COD-53] Added spec for courses searching
…ed users see course list
…urrent user (backend) [COD-53] Added user last name display
[COD-53] Added request spec for courses/show [COD-53] Added show service for courses, logic to course controller, fixed spec issues
[COD-53] Added lessons logic to course page (frontend)
…ckend) [COD-53] Added spec for lessons/index
…n a course page (frontend) [COD-53] Added button 'add lesson' to course page
MikhailZaitsau
requested review from
LorDEvilDead,
Set27,
SilaEwGenii,
npupko and
roman-dubrovsky
|
Can you make PR more pretty to read? 1 (# 1)2 (## 2)3 (### 3)to separate important parts of the pull request. Additionally, making a list of changes will help to read it.
Sign a screenshot to make sure that a reader understands the context. |
| in Success(*courses_found) | ||
| render json: courses_found, status: :ok |
There was a problem hiding this comment.
courses_found is an array and using * we pass each element of the array as a separate argument. Then render each course?
E.g. courses_found = [course1, course2, course3]. Success(*courses_found) will render Sucess three times? Or I am wrong?
There was a problem hiding this comment.
If I clearly understand * in DryMonads use to capture an array value. You can read more about this here: https://dry-rb.org/gems/dry-monads/1.3/pattern-matching/
| factory :course do | ||
| name { 'MyString' } | ||
| user | ||
| name { Faker::Hacker.say_something_smart } |
There was a problem hiding this comment.
Can this method return a string length more than we expect in the model?
There was a problem hiding this comment.
No. It never return more than 256 symbols.
MikhailZaitsau
force-pushed
the
COD-53-Verify-complete-flow-and-add-missing-parts
branch
from
34d5dd1 to
42a855b
Compare
2 participants
Next flow was checked by me and completed to work fine:
Link to JIRA issue.
Page "My courses" let user search and see all courses created by him:
Page "All courses" let user search and see all courses:
On course page user can see all attached lessons and add new one:
