Skip to content

Proposal: Add pre-commit config to repo#932

Open
mashehu wants to merge 2 commits intoScilifelabDataCentre:devfrom
mashehu:add-pre-commit-hook
Open

Proposal: Add pre-commit config to repo#932
mashehu wants to merge 2 commits intoScilifelabDataCentre:devfrom
mashehu:add-pre-commit-hook

Conversation

@mashehu
Copy link
Copy Markdown
Contributor

@mashehu mashehu commented Feb 27, 2026

Pull Request Template

Before Marking as Ready for Review

  • Add relevant information to the sections below (Summary etc)
  • Rebase or merge the latest dev (or other targeted branch)
  • Update documentation if needed
  • Add an entry to the SPRINTLOG.md if needed
  • Choose an appropriate label. See here for information on the labelling options
  • The code follows the style guidelines
  • Perform a self-review: read the diff as if reviewing someone else's code
  • I have commented the code, particularly in hard-to-understand areas
  • [] Verify that all checks and tests have passed

Summary

Because I just saw the linting errors in my previous PR after I pushed, I would propose have a pre-commit-config.
This makes the linting CI easier to manage.

Future considerations:

  • replace yaml-lint with prettier (I don't think you need any of the fancy parts of yaml-lint)
  • add trailing-whitespace and end-of-file-fixer hooks to keep the repo even more in shpae

@mashehu
Copy link
Copy Markdown
Contributor Author

mashehu commented Feb 27, 2026

Last maintenance PR from my side, I promise 😁

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.45%. Comparing base (1c9f388) to head (5069609).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #932   +/-   ##
=======================================
  Coverage   54.45%   54.45%           
=======================================
  Files          33       33           
  Lines        3043     3043           
=======================================
  Hits         1657     1657           
  Misses       1386     1386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu marked this pull request as ready for review March 9, 2026 12:10
@mashehu mashehu requested a review from a team as a code owner March 9, 2026 12:10
@mashehu mashehu force-pushed the add-pre-commit-hook branch from 9020cd6 to 5069609 Compare March 9, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant