Proposal: Add pre-commit config to repo#932
Open
mashehu wants to merge 2 commits intoScilifelabDataCentre:devfrom
Open
Proposal: Add pre-commit config to repo#932mashehu wants to merge 2 commits intoScilifelabDataCentre:devfrom
mashehu wants to merge 2 commits intoScilifelabDataCentre:devfrom
Conversation
Contributor
Author
|
Last maintenance PR from my side, I promise 😁 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #932 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 33 33
Lines 3043 3043
=======================================
Hits 1657 1657
Misses 1386 1386 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9020cd6 to
5069609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Before Marking as Ready for Review
dev(or other targeted branch)SPRINTLOG.mdif neededSummary
Because I just saw the linting errors in my previous PR after I pushed, I would propose have a pre-commit-config.
This makes the linting CI easier to manage.
Future considerations: