lfk: Add version 0.14.18#18155
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a Scoop manifest for Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
bucket/lfk.json (2)
32-35: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider relying on Scoop's default hash extraction.
The explicit
"regex": "$sha256 $basename\\n"works for standardsha256sumoutput, but it assumes a specific field ordering and spacing. Scoop's built-in$filenameRegexalready handles basename matching and supports both<hash> <filename>and<filename> <hash>orderings. Unless thechecksums.txtformat deviates from standard patterns, you can simplify this block to just"url": "$baseurl/checksums.txt"and let the default extraction handle it.Based on learnings, when
autoupdate.hash.urlpoints to a shared checksum file with multiple architecture entries, you typically do not need an explicit custom regex if the format matches standard patterns.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/lfk.json` around lines 32 - 35, The hash block uses a custom regex in the Scoop manifest, but this can usually be simplified by relying on Scoop’s default hash extraction. Update the hash configuration in the manifest so the shared checksums file is consumed with only the URL, and remove the explicit regex unless the checksum format truly needs custom parsing; use the existing hash/autoupdate.hash handling in this manifest to keep it aligned with Scoop’s built-in filename matching.Source: Learnings
1-37: 🧹 Nitpick | 🔵 TrivialTest guidance for manifest verification.
Before submission, please verify the manifest locally:
# Enable debug mode and set GitHub token (for releases API access) scoop config debug true scoop config gh_token <your-github-token> # Read access only # Force version detection and autoupdate check .\bin\checkver.ps1 -App lfk -f # Auto-format (lint) the JSON manifest .\bin\formatjson.ps1 -App lfk # Test installation for each architecture scoop install bucket/lfk.json -a 64bit scoop install bucket/lfk.json -a arm64As per path instructions, these steps help catch autoupdate, formatting, and installation issues early.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/lfk.json` around lines 1 - 37, The manifest file includes test guidance text that does not belong in a Scoop JSON manifest and should be removed. Keep bucket/lfk.json limited to valid manifest fields such as version, architecture, env_set, bin, checkver, and autoupdate, and move the verification steps to documentation or the PR description instead of the manifest content.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/lfk.json`:
- Around line 32-35: The hash block uses a custom regex in the Scoop manifest,
but this can usually be simplified by relying on Scoop’s default hash
extraction. Update the hash configuration in the manifest so the shared
checksums file is consumed with only the URL, and remove the explicit regex
unless the checksum format truly needs custom parsing; use the existing
hash/autoupdate.hash handling in this manifest to keep it aligned with Scoop’s
built-in filename matching.
- Around line 1-37: The manifest file includes test guidance text that does not
belong in a Scoop JSON manifest and should be removed. Keep bucket/lfk.json
limited to valid manifest fields such as version, architecture, env_set, bin,
checkver, and autoupdate, and move the verification steps to documentation or
the PR description instead of the manifest content.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9df62e21-4f74-4642-b0ce-26d39c7cd03e
📒 Files selected for processing (1)
bucket/lfk.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. lfk
|
1 participant
Closes #17823
Adds a Scoop manifest for lfk v0.14.18 - a lightning-fast, keyboard-focused, yazi-inspired terminal UI for navigating and managing Kubernetes clusters (543 stars).
Manifest details:
Windows AMD64 and ARM64 downloads with verified SHA-256 hashes from the release
checksums.txt.bin: lfk.exe(the binary is at the zip root, no rename needed).env_setmaps config/state/data dirs under$persist_dir.checkver+autoupdateconfigured for future releases.Use conventional PR title:
<manifest-name[@version]|chore>: <general summary of the pull request>I have read the Contributing Guide