openwhispr: Add version 1.7.3#18190
Conversation
|
/verify |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new Scoop manifest file Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. openwhispr
|
There was a problem hiding this comment.
Pull request overview
Adds a new Scoop manifest to the Extras bucket for OpenWhispr v1.7.3, enabling installation and future updates via GitHub Releases.
Changes:
- Introduces a new
bucket/openwhispr.jsonmanifest for OpenWhispr v1.7.3. - Implements NSIS/Electron extraction behavior (via
#/dl.7z+Expand-7zipArchive) and creates a Start Menu shortcut. - Adds
checkver/autoupdatewiring for tracking upstream releases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "url": "https://github.com/OpenWhispr/openwhispr/releases/download/v1.7.3/OpenWhispr-Setup-1.7.3.exe#/dl.7z", | ||
| "hash": "256a49099fc6f8ed2b81c7898f8dac704ee7190ccca76cc351508cafcd0a3f55", | ||
| "architecture": { | ||
| "64bit": { | ||
| "pre_install": "Expand-7zipArchive \"$dir\\`$PLUGINSDIR\\app-64.7z\" \"$dir\"" | ||
| } | ||
| }, |
| "autoupdate": { | ||
| "url": "https://github.com/OpenWhispr/openwhispr/releases/download/v$version/OpenWhispr-Setup-$version.exe#/dl.7z" | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/openwhispr.json (1)
20-25: 📐 Maintainability & Code Quality | 🔵 TrivialPlease run the standard Scoop manifest checks before merge.
For a new
bucket/manifest, I'd still validate it with:scoop config debug true scoop config gh_token <your-github-token> # Read access only .\bin\checkver.ps1 -App openwhispr -f .\bin\formatjson.ps1 -App openwhispr scoop install bucket/openwhispr.json -a 64bitAs per path instructions, new manifests should be validated with
checkver,formatjson, and an install test.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/openwhispr.json` around lines 20 - 25, The new bucket manifest needs standard Scoop validation before merge. Check the openwhispr manifest with checkver and formatjson, then verify it installs successfully using the package name from the manifest. Use the manifest’s checkver and autoupdate fields to confirm version matching and download URL correctness, and make sure the install test passes for the 64-bit package.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/openwhispr.json`:
- Around line 20-25: The new bucket manifest needs standard Scoop validation
before merge. Check the openwhispr manifest with checkver and formatjson, then
verify it installs successfully using the package name from the manifest. Use
the manifest’s checkver and autoupdate fields to confirm version matching and
download URL correctness, and make sure the install test passes for the 64-bit
package.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f746ba70-2ac2-49f5-8b70-8808e1db7368
📒 Files selected for processing (1)
bucket/openwhispr.json
Moves top-level url/hash under architecture.64bit so Scoop correctly reports the app as unavailable on 32-bit. Also nests autoupdate.url under autoupdate.architecture.64bit.url. Fixes Copilot review comments: - discussion_r3498570265: url/hash at top level but pre_install under architecture.64bit causes broken installs on 32-bit - discussion_r3498570306: autoupdate must also be architecture-aware
Add OpenWhispr v1.7.3 — voice-to-text dictation app with local/cloud models, privacy-first, MIT license.
Closes #18189