Skip to content

tinyretropad: Add version 2026.06.29#18213

Closed
Jogai wants to merge 1 commit into
ScoopInstaller:masterfrom
Jogai:add-trp
Closed

tinyretropad: Add version 2026.06.29#18213
Jogai wants to merge 1 commit into
ScoopInstaller:masterfrom
Jogai:add-trp

Conversation

@Jogai

@Jogai Jogai commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Running out of time to create an issue, so, take it or leave it :) issue made at #18214

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request adds a new Scoop manifest file, bucket/tinyretropad.json, for the TinyRetroPad Windows x86 assembly text editor. The manifest includes version and description metadata, homepage, license, and notes, a pinned download URL tied to a specific commit, a SHA-256 hash, the executable name, a shortcut definition, and an autoupdate configuration that derives version and download URL from GitHub commit data.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: package-request-needed, not-meet-criteria

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and matches the main change: adding a TinyRetroPad manifest version.
Description check ✅ Passed The description includes the required checklist items and references issue #18214, though it does not use the template's issue line format.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added not-meet-criteria This package doesn't fully meet the essential criteria to be accepted in Extras bucket. package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. labels Jul 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/tinyretropad.json`:
- Around line 3-6: The TinyRetroPad manifest is missing the required linked
package-request issue reference and explicit maintainer approval exception.
Update the manifest metadata (for example in the description or notes of the
tinyretropad entry) to include the package-request issue link, and ensure the
request is clearly marked as approved by a maintainer since the upstream has no
formal releases.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 70385dbb-ed1f-4664-b608-955405388a8d

📥 Commits

Reviewing files that changed from the base of the PR and between 43f3b21 and 89d4ca0.

📒 Files selected for processing (1)
  • bucket/tinyretropad.json

Comment thread bucket/tinyretropad.json
@z-Fng z-Fng removed the not-meet-criteria This package doesn't fully meet the essential criteria to be accepted in Extras bucket. label Jul 2, 2026
@aliesbelik aliesbelik linked an issue Jul 2, 2026 that may be closed by this pull request
6 tasks
@aliesbelik aliesbelik removed the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Jul 2, 2026
@aliesbelik

Copy link
Copy Markdown
Collaborator

/verify

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

tinyretropad

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Jogai

Jogai commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/merge 😄

@z-Fng z-Fng changed the title Tinyretropad: Add version 2026.06.29 tinyretropad: Add version 2026.06.29 Jul 4, 2026
Comment thread bucket/tinyretropad.json
"description": "A Notepad-style Windows text editor written in x86 assembly, in roughly 2.5 KB.",
"homepage": "https://github.com/plummersSoftwareLLC/TinyRetroPad",
"license": "Apache-2.0",
"notes": "Upstream ships no releases; this manifest is pinned to a commit and versioned by its date. Built with Crinkler compression, so it may be flagged as a false positive by antivirus.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criteria

  • Latest stable version

Better to wait for upstream to merge the release PR before adding it to extras.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think its that kind of project.

@z-Fng z-Fng closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: TinyRetroPad

3 participants