Skip to content

losslesscut: Improve notes, fix post_install script#18242

Merged
z-Fng merged 4 commits into
ScoopInstaller:masterfrom
NECOtype:losslesscut
Jul 7, 2026
Merged

losslesscut: Improve notes, fix post_install script#18242
z-Fng merged 4 commits into
ScoopInstaller:masterfrom
NECOtype:losslesscut

Conversation

@NECOtype

@NECOtype NECOtype commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

this PR is related to

and simply:
a) improves the post-install notes and makes it clearer
b) puts bin and shortcuts fields after post_install and before uninstaller (CONTRIBUTING)

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates bucket/losslesscut.json by changing the install-associations note to the full reg import command, adding a $global-dependent registry host replacement in post_install, moving bin and shortcuts after post_install, and simplifying the uninstall path to directly import uninstall-associations.reg when uninstalling.

Cohort / File Change Summary
bucket/losslesscut.json Updated install note text, added $global registry replacement in post_install, reordered manifest fields, and simplified uninstall registry import logic

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

The uninstall script checks for the uninstall command and then runs a direct reg import for the uninstall associations file.

Related issues: None referenced in the provided context.

Related PRs: None referenced in the provided context.

Suggested labels: manifest-update

Suggested reviewers: None specified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise, conventional, and matches the main changes to the losslesscut manifest.
Description check ✅ Passed The description includes related issues, a clear summary, and the required checklist items, so it is mostly complete.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NECOtype

NECOtype commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

losslesscut

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title losslesscut: improves post-install notes & updates general order of fields losslesscut: Improve notes & Update general order of fields Jul 7, 2026
@github-actions

This comment was marked as outdated.

@z-Fng

z-Fng commented Jul 7, 2026

Copy link
Copy Markdown
Member

/verify

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/losslesscut.json`:
- Around line 34-38: The uninstaller manifest has invalid JSON because the
uninstaller script is defined as an array containing a nested "script" key/value
pair, which breaks parsing. Fix the "uninstaller" entry in losslesscut.json by
collapsing the malformed "script" structure into one valid property using either
a single string or a proper one-item array, and remove the duplicated inner
"script" key so the uninstall command is represented correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 283953fe-0a20-482b-ba27-76a9d84f0a3a

📥 Commits

Reviewing files that changed from the base of the PR and between c2bea8b and 58a79fa.

📒 Files selected for processing (1)
  • bucket/losslesscut.json

Comment thread bucket/losslesscut.json
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

losslesscut

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title losslesscut: Improve notes & Update general order of fields losslesscut: Improve notes, fix post_install script Jul 7, 2026
@z-Fng z-Fng merged commit 8b08fd0 into ScoopInstaller:master Jul 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants