Skip to content

tablecloth: Add version 1.20.5#18260

Open
fi-xz wants to merge 1 commit into
ScoopInstaller:masterfrom
fi-xz:tablecloth
Open

tablecloth: Add version 1.20.5#18260
fi-xz wants to merge 1 commit into
ScoopInstaller:masterfrom
fi-xz:tablecloth

Conversation

@fi-xz

@fi-xz fi-xz commented Jul 8, 2026

Copy link
Copy Markdown

Closes #18259

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8ff6dff-2c21-47f3-afba-840e14c36bd6

📥 Commits

Reviewing files that changed from the base of the PR and between 8d13653 and 98c95e0.

📒 Files selected for processing (1)
  • bucket/tablecloth.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/tablecloth.json

📝 Walkthrough

Walkthrough

This change adds a new Scoop bucket manifest, bucket/tablecloth.json, for TableCloth version 1.20.5. The manifest includes package metadata, 64-bit and arm64 download URLs with SHA-256 hashes, extraction to current, a post_install PowerShell script that creates the data directories and writes Preferences.json, a TableCloth.exe shortcut, persistence for Data, and GitHub-based checkver/autoupdate settings.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, conventional, and accurately names the TableCloth 1.20.5 manifest addition.
Description check ✅ Passed The description includes the linked issue and the required checklist items from the template.
Linked Issues check ✅ Passed The manifest adds TableCloth 1.20.5 with the specified x64 and arm64 download URLs, matching the request.
Out of Scope Changes check ✅ Passed All changes are confined to the new TableCloth manifest and stay within the requested package addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fi-xz

fi-xz commented Jul 8, 2026

Copy link
Copy Markdown
Author

/verify

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

tablecloth

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
bucket/tablecloth.json (2)

20-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add an uninstaller script to clean up $env:LOCALAPPDATA\TableCloth.Data.

The post_install creates a directory and Preferences.json in $env:LOCALAPPDATA\TableCloth.Data that will persist after uninstall. Add an uninstaller block to remove them.

♻️ Proposed addition
     "persist": "Data",
+    "uninstaller": {
+        "script": "Remove-Item \"$env:LOCALAPPDATA\\TableCloth.Data\" -Force -Recurse -ErrorAction SilentlyContinue"
+    },
     "checkver": "github",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/tablecloth.json` around lines 20 - 31, The package setup in
tablecloth.json creates persistent files under $env:LOCALAPPDATA\TableCloth.Data
via the post_install logic, but there is no cleanup on uninstall. Add an
uninstaller script block alongside post_install that removes the TableCloth.Data
local app data directory and its Preferences.json file, using the same
$appDataDirName and $localAppDataPath identifiers so the cleanup targets the
exact paths created during install.

1-47: 📐 Maintainability & Code Quality | 🔵 Trivial

Ensure CRLF line endings and test the manifest locally before submission.

Scoop manifests must use CRLF line endings. Verify this in your editor or with formatjson.ps1.

Test guidance:

# Optional: enable debug mode
scoop config debug true

# Force version detection and autoupdate
.\bin\checkver.ps1 -App tablecloth -f

# Auto-format (lint) the JSON manifest
.\bin\formatjson.ps1 -App tablecloth

# Test installation for each architecture
scoop install bucket/tablecloth.json -a 64bit
scoop install bucket/tablecloth.json -a arm64

Related links:

As per path instructions, Scoop manifests must use CRLF line endings and should be tested locally before submission.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/tablecloth.json` around lines 1 - 47, The manifest in tablecloth.json
needs CRLF line endings and should be validated locally before submission.
Ensure the JSON file uses Windows-style CRLF throughout, then run the Scoop
manifest checks for this bucket entry using the standard tooling (for example
the format/lint and install tests) to confirm the manifest is clean and
installable for both 64bit and arm64.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/tablecloth.json`:
- Around line 20-31: The package setup in tablecloth.json creates persistent
files under $env:LOCALAPPDATA\TableCloth.Data via the post_install logic, but
there is no cleanup on uninstall. Add an uninstaller script block alongside
post_install that removes the TableCloth.Data local app data directory and its
Preferences.json file, using the same $appDataDirName and $localAppDataPath
identifiers so the cleanup targets the exact paths created during install.
- Around line 1-47: The manifest in tablecloth.json needs CRLF line endings and
should be validated locally before submission. Ensure the JSON file uses
Windows-style CRLF throughout, then run the Scoop manifest checks for this
bucket entry using the standard tooling (for example the format/lint and install
tests) to confirm the manifest is clean and installable for both 64bit and
arm64.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b1056bae-bb98-4078-ba43-925cc7111dd2

📥 Commits

Reviewing files that changed from the base of the PR and between edfe2f3 and 24652f5.

📒 Files selected for processing (1)
  • bucket/tablecloth.json

@fi-xz

fi-xz commented Jul 8, 2026

Copy link
Copy Markdown
Author

/verify

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

tablecloth

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: tablecloth

1 participant