tablecloth: Add version 1.20.5#18260
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change adds a new Scoop bucket manifest, Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with tablecloth
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
bucket/tablecloth.json (2)
20-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd an
uninstallerscript to clean up$env:LOCALAPPDATA\TableCloth.Data.The
post_installcreates a directory andPreferences.jsonin$env:LOCALAPPDATA\TableCloth.Datathat will persist after uninstall. Add anuninstallerblock to remove them.♻️ Proposed addition
"persist": "Data", + "uninstaller": { + "script": "Remove-Item \"$env:LOCALAPPDATA\\TableCloth.Data\" -Force -Recurse -ErrorAction SilentlyContinue" + }, "checkver": "github",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/tablecloth.json` around lines 20 - 31, The package setup in tablecloth.json creates persistent files under $env:LOCALAPPDATA\TableCloth.Data via the post_install logic, but there is no cleanup on uninstall. Add an uninstaller script block alongside post_install that removes the TableCloth.Data local app data directory and its Preferences.json file, using the same $appDataDirName and $localAppDataPath identifiers so the cleanup targets the exact paths created during install.
1-47: 📐 Maintainability & Code Quality | 🔵 TrivialEnsure CRLF line endings and test the manifest locally before submission.
Scoop manifests must use CRLF line endings. Verify this in your editor or with
formatjson.ps1.Test guidance:
# Optional: enable debug mode scoop config debug true # Force version detection and autoupdate .\bin\checkver.ps1 -App tablecloth -f # Auto-format (lint) the JSON manifest .\bin\formatjson.ps1 -App tablecloth # Test installation for each architecture scoop install bucket/tablecloth.json -a 64bit scoop install bucket/tablecloth.json -a arm64Related links:
As per path instructions, Scoop manifests must use CRLF line endings and should be tested locally before submission.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/tablecloth.json` around lines 1 - 47, The manifest in tablecloth.json needs CRLF line endings and should be validated locally before submission. Ensure the JSON file uses Windows-style CRLF throughout, then run the Scoop manifest checks for this bucket entry using the standard tooling (for example the format/lint and install tests) to confirm the manifest is clean and installable for both 64bit and arm64.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/tablecloth.json`:
- Around line 20-31: The package setup in tablecloth.json creates persistent
files under $env:LOCALAPPDATA\TableCloth.Data via the post_install logic, but
there is no cleanup on uninstall. Add an uninstaller script block alongside
post_install that removes the TableCloth.Data local app data directory and its
Preferences.json file, using the same $appDataDirName and $localAppDataPath
identifiers so the cleanup targets the exact paths created during install.
- Around line 1-47: The manifest in tablecloth.json needs CRLF line endings and
should be validated locally before submission. Ensure the JSON file uses
Windows-style CRLF throughout, then run the Scoop manifest checks for this
bucket entry using the standard tooling (for example the format/lint and install
tests) to confirm the manifest is clean and installable for both 64bit and
arm64.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b1056bae-bb98-4078-ba43-925cc7111dd2
📒 Files selected for processing (1)
bucket/tablecloth.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. tablecloth
|
Closes #18259
<manifest-name[@version]|chore>: <general summary of the pull request>