[Tests]: add test coverage for generate_mnemonic_from_coin_flips and get_partial_final_word#918
Open
S1DDHEY wants to merge 2 commits into
Open
[Tests]: add test coverage for generate_mnemonic_from_coin_flips and get_partial_final_word#918S1DDHEY wants to merge 2 commits into
S1DDHEY wants to merge 2 commits into
Conversation
aphrodoe
reviewed
Apr 14, 2026
aphrodoe
left a comment
There was a problem hiding this comment.
All tests verified correct. I independently recomputed expected mnemonics and partial words against embit.
ACK as it is tests only, no production code changes.
Collaborator
|
Does this PR increase code coverage (https://github.com/SeedSigner/seedsigner/tree/dev/tests#generate-coverage-manually) ? If so, can the diff of percentage increase or line number increase be posted? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Problem or Issue being addressed
generate_mnemonic_from_coin_flips()andget_partial_final_word()inhelpers/mnemonic_generation.pyhad zero test coverage despite being user-facing seed generation paths.Solution
Added 7 new tests to
test_mnemonic_generation.pycovering:generate_mnemonic_from_coin_flips():get_partial_final_word():Additional Information
All tests were cross-verified using emulator with the Tools --> Calc 12th/24th word --> Coin flip entropy flow.
Part of Summer of Bitcoin
Screenshots
N/A, no UI changes.
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes:
Thank you! Please join our Devs' Telegram group to get more involved.