Fix cleanup UI - #293
Open
Sendipad wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have completed the deep architectural audit of the UI control system. The findings, root causes, responsibility map, divergence from native Frappe, proposed refactoring plan, and regression matrix have been documented in the implementation_plan.md artifact for your review.
, I have focused on identifying the underlying architectural issues rather than superficial bug fixes. The most critical issue discovered is the tight coupling of individual controls (like MultiSelectList) to global Frappe state (window.frappe.query_report), which breaks completely when they are rendered inside the isolated environment of the Rule Builder's QueryRecordsConfig adapter. This, along with fragmented dependency resolution and isolated caching, is the root cause of the inconsistent behavior you've observed.