Refactor UI controls and enforce state synchronization - #295
Open
ruzaqiarkan-eng wants to merge 3 commits into
Open
Refactor UI controls and enforce state synchronization#295ruzaqiarkan-eng wants to merge 3 commits into
ruzaqiarkan-eng wants to merge 3 commits into
Conversation
…undaries Refactors the UI control system to decouple ComboBoxControl, MultiSelectList, and FlexValueControl from host-specific global states (window.frappe). Values and dynamic target DocTypes are resolved purely via the injected ControlContext and centralized resolution helpers. Additionally: - Modifies useAsyncOptionsSource to deeply watch reactive dependencies for cache invalidation. - Standardizes link search queries using a buildSearchRequest builder helper. - Enforces strict immutability boundaries across FilterGroup, QueryRecordsConfig, and useActionConfig using the cloneForEmit helper to ensure precise Pinia snapshot and dirty tracking.
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…undaries Refactors the UI control system to decouple ComboBoxControl, MultiSelectList, and FlexValueControl from host-specific global states (window.frappe). Values and dynamic target DocTypes are resolved purely via the injected ControlContext and centralized resolution helpers. Additionally: - Modifies useAsyncOptionsSource to deeply watch reactive dependencies for cache invalidation. - Standardizes link search queries using a buildSearchRequest builder helper. - Enforces strict immutability boundaries across FilterGroup, QueryRecordsConfig, and useActionConfig using the cloneForEmit helper to ensure precise Pinia snapshot and dirty tracking. - Formats all modified files with Prettier.
…undaries Refactors the UI control system to decouple ComboBoxControl, MultiSelectList, and FlexValueControl from host-specific global states (window.frappe). Values and dynamic target DocTypes are resolved purely via the injected ControlContext and centralized resolution helpers. Additionally: - Modifies useAsyncOptionsSource to deeply watch reactive dependencies for cache invalidation. - Standardizes link search queries using a buildSearchRequest builder helper. - Enforces strict immutability boundaries across FilterGroup, QueryRecordsConfig, and useActionConfig using the cloneForEmit helper to ensure precise Pinia snapshot and dirty tracking. - Formats all modified files with Prettier 2.7.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the UI control system to cleanly separate concerns of search request building, target doctype resolution, and data caching. Direct accesses to window.frappe within MultiSelectList, ComboBoxControl, and FlexValueControl have been completely eliminated. Implemented reactive dependency-agnostic invalidation in useAsyncOptionsSource and enforced strict immutable updates on configuration mutations using deep cloning helpers to guarantee highly precise dirty tracking.
PR created automatically by Jules for task 3026482131003023734 started by @ruzaqiarkan-eng