Skip to content

newFee can equals maxStreamingFeePercentage in StreamingFeeModule#224

Open
gzliudan wants to merge 1 commit intoSetProtocol:masterfrom
gzliudan:StreamingFeeModule
Open

newFee can equals maxStreamingFeePercentage in StreamingFeeModule#224
gzliudan wants to merge 1 commit intoSetProtocol:masterfrom
gzliudan:StreamingFeeModule

Conversation

@gzliudan
Copy link
Contributor

In StreamingFeeModule, streamingFeePercentage can be equal to maxStreamingFeePercentage when initialize:

require(_settings.streamingFeePercentage <= _settings.maxStreamingFeePercentage, "Fee must be <= max.");

But when updateStreamingFee _newFee can't be equal to _maxStreamingFeePercentage:

require(_newFee < _maxStreamingFeePercentage(_setToken), "Fee must be less than max");

It seems that use <= to check is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant