Open
Conversation
Contributor
|
Also looks like the integration tests are failing on CI |
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts
Outdated
Show resolved
Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts
Outdated
Show resolved
Hide resolved
contracts/protocol/integration/exchange/VelodromeExchangeAdapter.sol
Outdated
Show resolved
Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts
Outdated
Show resolved
Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
FlattestWhite
left a comment
FlattestWhite
left a comment
There was a problem hiding this comment.
mostly looks pretty good - I'm just wondering with all the extra interface objects, where they are needed. I was under the impression only the abi json files are required
Contributor
FlattestWhite
left a comment
FlattestWhite
left a comment
There was a problem hiding this comment.
nearly there - a few more comments on the style of the unit test to be consistent with set's expected style
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts
Outdated
Show resolved
Hide resolved
test/protocol/integration/exchange/velodromeExchangeAdapter.spec.ts
Outdated
Show resolved
Hide resolved
FlattestWhite
approved these changes
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Velodrome Exchange Adapter - https://www.pivotaltracker.com/n/projects/2535878/stories/182552344