Show payment method brand logos for Quickpay methods on the checkout - #125
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #125 +/- ##
============================================
+ Coverage 83.77% 85.99% +2.21%
- Complexity 125 154 +29
============================================
Files 16 20 +4
Lines 530 614 +84
============================================
+ Hits 444 528 +84
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
loevgaard
force-pushed
the
checkout-payment-method-logos
branch
3 times, most recently
from
August 17, 2026 11:29
6877f47 to
d36afdf
Compare
Each Quickpay payment method on the checkout payment step now shows the brands its payment window will offer, derived from the gateway configuration's payment_methods option — nothing is configured twice and no API is called. PaymentMethodLogoProvider parses Quickpay's token grammar (exclusions, the 3d- prefix, regional/debit variants collapsing onto their brand, creditcard expanding to a configurable brand list) and maps tokens to bundled SVGs; a token without a logo renders as a text label. Rendered through a Twig function by a sylius_ui block on sylius.shop.checkout.select_payment.choice_item_content. The SVGs are Shopify's MIT-licensed activemerchant/payment_icons (attribution README next to them) and cover cards, Dankort, MobilePay, Apple/Google Pay, Klarna, Anyday, Vipps, Swish, PayPal, ViaBill, Trustly, iDEAL, Sofort and paysafecard. Shops add/override/hide logos through the new checkout.payment_method_logos and checkout.creditcard_brands configuration. Closes #108
loevgaard
force-pushed
the
checkout-payment-method-logos
branch
from
August 17, 2026 11:45
d36afdf to
d0bd832
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Quickpay payment method on the checkout payment step now shows the brands its payment window will offer, derived from the gateway configuration's
payment_methodsoption — nothing is configured twice, no API is called.Checkout/PaymentMethodLogoProviderparses Quickpay's token grammar (!exclusions,3d-prefix, regional/debit variants likevisa-dk/mastercard-debet-dk/mobilepay-subscriptionscollapsing onto their brand,creditcardexpanding to a configurable brand list) and maps tokens to bundled SVGs; unknown tokens render as a text labelsylius_uiblock onsylius.shop.checkout.select_payment.choice_item_content(verified rendering through the booted test app)assets:install(README step added)checkout.payment_method_logos(add/override/hide per token) andcheckout.creditcard_brands90 tests, PHPStan max, ECS, Rector, YAML/twig/container lint green.
Closes #108
First of a stack: this → #126.