Skip to content

fix(android-sample): let a guest cart take the shop market - #570

Open
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/e2e-checkout-customer-accountfrom
kieran-osgood/android-guest-cart-market
Open

fix(android-sample): let a guest cart take the shop market#570
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/e2e-checkout-customer-accountfrom
kieran-osgood/android-guest-cart-market

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

TLDR

Android sample diverges from other samples by giving a guest cart a hardcoded Canadian buyer identity.
I'm removing the hardcode.

- buyerIdentity = Optional.present(CartBuyerIdentityInput(countryCode = Optional.present(CountryCode.CA)))
+ buyerIdentity = Optional.Absent

Why

A country on the buyer identity picks the market. The market decides the currency, the address form, and the labels on its fields. So the Android sample rendered a Canadian checkout, while the shared E2E fixture types a United States address.

This was detected as a fault in some of the tests

`e2e/FLAKES.md`: `checkout-guest` failed on Kotlin Android at
`Scrolling DOWN until "Country/Region" is visible`, and passed on React Native Android.

React Native also skipped the country picker step, because United States was already selected. The Kotlin failure screenshot shows a total in CAD.

Scope

This change is scoped to

  • Sample app
  • Guest path

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-checkout-customer-account to graphite-base/570 August 5, 2026 09:22
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from 4ac9954 to 6643cfb Compare August 5, 2026 09:53
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/570 to kieran-osgood/e2e-checkout-customer-account August 5, 2026 09:53
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-checkout-customer-account to graphite-base/570 August 5, 2026 11:06
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from 6643cfb to 6bff379 Compare August 6, 2026 15:48
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/570 to kieran-osgood/e2e-checkout-customer-account August 6, 2026 15:49
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from 6bff379 to 9ceb6c5 Compare August 6, 2026 17:30
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-customer-account branch from 398373e to ae576c3 Compare August 6, 2026 17:30
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from 9ceb6c5 to 4289c70 Compare August 7, 2026 11:05
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-customer-account branch 2 times, most recently from 739c95b to 028246e Compare August 7, 2026 11:25
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from 4289c70 to d67c16c Compare August 7, 2026 11:25
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-customer-account branch from 028246e to f3bba28 Compare August 7, 2026 13:51
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch 2 times, most recently from 4e6d2bf to cf7a21e Compare August 7, 2026 14:15
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-customer-account branch from f3bba28 to b874950 Compare August 7, 2026 14:15
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-checkout-customer-account to graphite-base/570 August 10, 2026 09:08
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review August 11, 2026 13:48
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner August 11, 2026 13:48
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 281.8 KiB 281.8 KiB 0 B
Android file breakdown
File Base Head Delta
classes.jar 297.7 KiB 297.7 KiB 0 B
res/layout/checkout_view_content.xml 2.6 KiB 2.6 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.3 KiB 1.3 KiB 0 B
R.txt 1.2 KiB 1.2 KiB 0 B
AndroidManifest.xml 922 B 922 B 0 B
proguard.txt 798 B 798 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@bitrise

bitrise Bot commented Aug 11, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
Kotlin Install with Tophat

Checkout Kit E2E results

Status Tags Target Platform OS version tag Device
launch, checkout, account kotlin android latest Google Pixel 9
Android 17.0

Failures

Caution

These E2E checks are not yet required, so they do not block merging — but a failure may still indicate a real issue to resolve before merging.
If you believe an assertion is flaky, please raise a ticket in the #checkout-kit-devs channel so it can be addressed.

BrowserStack artifacts require BrowserStack access. Sign in to BrowserStack App Automate before opening artifact links.

Android — kotlin

Test Status Artifacts
./tests/shared/checkout-guest BrowserStack · Video · Screenshot · Maestro commands · Maestro log

@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from cf7a21e to 5f180c4 Compare August 12, 2026 12:27
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/570 to kieran-osgood/e2e-checkout-customer-account August 12, 2026 12:28
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-customer-account branch from 1ef701e to 4adf1f2 Compare August 12, 2026 12:35
The Android sample gave a guest cart a Canadian buyer identity. A country on
the buyer identity picks the market, and the market decides the currency, the
address form and its labels, so the Kotlin checkout rendered a Canadian form
and totalled in CAD.

The Swift and React Native samples send no buyer identity for a guest, so this
one now sends none either. This is flake B4: the shared E2E fixture is a United
States address, and checkout-guest failed on Kotlin Android while React Native
Android passed the same test.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Assisted-By: devx/5b4b8d5b-690a-4389-841e-039723ade1da
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/android-guest-cart-market branch from 5f180c4 to 5027eb8 Compare August 12, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants