[POC] WebAuthn CLI #2 - Sockets - #67
Closed
jenshenny wants to merge 9 commits into
Closed
Conversation
jenshenny
force-pushed
the
webauthn-cli-2
branch
from
December 14, 2022 16:25
9e98984 to
4e81c17
Compare
|
Closing as we are moving to the proper implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you solving?
Prototype PR to adds support for WebAuthn on the CLI. Changes to the client can be found here: Client PR: Shopify/rubygems#37
Resources:
CLI Flows: https://docs.google.com/document/d/1FlIfW-zmvLmflOvo7oOUuEleQBTodo-8lVJdiRcYySw/edit#heading=h.kjywlfxfaool
What approach did you choose and why?
This flow is similar to the first prototype #56. and functionality is built from this prototype.
The main addition is 06bae61 and 4e81c17 commits.
It accepts a redirect_uri, and after the webauthn verification is completed, the rubygems.org server will redirect to the to the redirect_uri where the code will be sent as a param. The value of the redirect_uri is a localhost port. The response from the rubygems client will be render on the UI if successful.
I don't think we need to have preflight requests but not sure if there's a way to disable it currently. More info on preflight requests https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request
Demo
Screen.Recording.2022-12-14.at.11.16.45.AM.mov
Notes / Stuff I haven't explored