Update translation of RBS abstract methods to conditionally call super#853
Open
jesse-shopify wants to merge 1 commit intomainfrom
Open
Update translation of RBS abstract methods to conditionally call super#853jesse-shopify wants to merge 1 commit intomainfrom
jesse-shopify wants to merge 1 commit intomainfrom
Conversation
paracycle
approved these changes
Jan 26, 2026
d1171aa to
1f9543f
Compare
Morriar
approved these changes
Jan 26, 2026
| visit_scope(node) { super } | ||
| end | ||
|
|
||
| ABSTRACT_METHOD_BODY = "defined?(super) ? super : raise(NotImplementedError, \"Abstract method called\")" |
Contributor
There was a problem hiding this comment.
As a follow up, it would be nice to provide the replacement through the translator options:
# does not rewrite abstract methods
SorbetSigsToRBSComments.new(
translate_abstract_methods: nil
)
# old behavior, uses only raise
SorbetSigsToRBSComments.new(
translate_abstract_methods: "raise NotImplementedError, \"Abstract method called\""
)
# new behavior, uses defined super
SorbetSigsToRBSComments.new(
translate_abstract_methods: "defined?(super) ? super : raise(NotImplementedError, \"Abstract method called\")"
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When translating signatures into RBS on abstract methods, use the following pattern instead of a raise:
This requires sorbet support:
Questions