Hotfix: pass feedback env vars to Pages build#24
Merged
Conversation
kiyarose
force-pushed
the
hotfix/feedback-env-vars
branch
from
7c5bdc5 to
029c193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
VITE_FEEDBACK_FORM_ENDPOINTinto the Vite build environment.VITE_FEEDBACK_TURNSTILE_SITE_KEYas well, so custom feedback deployments do not fall back to the default site key.Why
The feedback page was showing the "not enabled" banner on the deployed site even when the repo variables were configured in GitHub Actions, because
.github/workflows/gh-pages.ymlwas not passing those variables into the build step.Verification
npx tsc -bnpm run build:checkwas not usable in this PowerShell workspace because the script uses a POSIX-styleSKIP_PWA=1assignment.