Add building and container recipes#30
Closed
jnagasawa wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#30jnagasawa wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
jnagasawa wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Conversation
…lication functionalities.
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Everything looks good here and works, thanks!
|
|
||
|
|
||
| # Set LD_LIBRARY_PATH to include /usr/local/lib for yaml-cpp | ||
| ENV LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH |
There was a problem hiding this comment.
FYI, LD_LIBRARY_PATH at the right-hand side is undefined at this point.
| # Set LD_LIBRARY_PATH to include /usr/local/lib for yaml-cpp | ||
| ENV LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH | ||
|
|
||
| WORKDIR /workdir |
There was a problem hiding this comment.
If there is a WORKDIR set, I would expect it to exist and have contents, independently of the user-defined mount.
| find_package(yaml-cpp REQUIRED) | ||
|
|
||
| # deal.II setup macro | ||
| DEAL_II_INITIALIZE_CACHED_VARIABLES() |
There was a problem hiding this comment.
FYI, in CMake, lowercase and uppercase are equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitlab username: nagasaji