Add hello/self tool (v0)#24
Open
jstjoe wants to merge 1 commit into
Open
Conversation
Simple health-check tool that echoes server name, version, vault ID, anonymous-mode flag, timestamp, and an optional personalized greeting.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
Code ReviewNice, tight v0. Handler is a pure function, follows the existing Bugs / correctness
Conventions / style (per CLAUDE.md)
Duplication / drift risk
Tests
Security
Overall: ship-ready once CLAUDE.md is updated to reflect the third tool and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helloMCP tool that acts as a health/self endpointnamearg)registerToolso it's text/structured-content onlyImplementation notes
src/lib/tools/hello.ts— pure function following the existingToolResult<T>pattern, no Skyflow API callssrc/server.ts; extractedSERVER_NAME/SERVER_VERSIONconstants and added agetCurrentVaultId()helper alongside the existinggetCurrentSkyflow()/isAnonymousMode()accessors/mcpendpoint already enforces)Test plan
pnpm test— 171 tests pass, including 5 newhandleHellocases (default greeting, personalized, whitespace-only name, metadata echo, ISO timestamp)pnpm build:server— clean tsc buildhellovia MCP Inspector to confirm structured output renders in a hostGenerated by Claude Code