Skip to content

spelling police at it again#1791

Open
Aed-1 wants to merge 2 commits intomainfrom
aed/grammar-police
Open

spelling police at it again#1791
Aed-1 wants to merge 2 commits intomainfrom
aed/grammar-police

Conversation

@Aed-1
Copy link
Copy Markdown
Member

@Aed-1 Aed-1 commented Mar 20, 2026

its spelled seconds not secconds

@github-actions github-actions bot added the Area: Translation Improvements or additions to translations label Mar 20, 2026
loucass003
loucass003 approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@loucass003 loucass003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZRock35 ZRock35 self-requested a review March 21, 2026 02:28
JovannMC
JovannMC approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JovannMC JovannMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sctanf
sctanf approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sctanf sctanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big if true

Eirenliel
Eirenliel requested changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change it needs to be beta tested

@kounocom kounocom requested a review from gorbit99 March 21, 2026 14:20
ButterscotchV
ButterscotchV requested changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Eiren, this is intertwined with really complex functionality and may cause unforeseen consequences. Please run a beta first and thoroughly test.

@kruemmelbande
Copy link
Copy Markdown
Contributor

kruemmelbande commented Mar 21, 2026

Review of merge request commit b8f1064 by deepseek v3.2:
Change Summary:

  • Fixed a typo in translation.ftl line 1605: "secconds" → "seconds"
    Code Review:
  • ✅ Correctness: The fix is accurate - "secconds" was misspelled
  • ✅ Scope: Change is limited to a single typo fix in a translation file
  • ✅ File Location: Appropriate (i18n translation file for English)
  • ✅ Impact: Minimal, only affects display text
  • ✅ Formatting: Maintains existing FTL (Fluent) format
    Suggestions:
  1. Commit message: The commit message "erm ackshullay" is humorous but not descriptive. A more professional message like "Fix typo: 'secconds' → 'seconds' in tracking checklist" would be better.
  2. Testing: Verify the change appears correctly in the UI by checking the tracking checklist.
    Overall: This is a simple, correct typo fix that improves text quality. The change is minimal and safe to merge.

@Eirenliel
Copy link
Copy Markdown
Member

Eirenliel commented Mar 21, 2026

@kruemmelbande clanker's opinion rejected ❌

kounocom
kounocom reviewed Mar 21, 2026
View reviewed changes
@Aed-1
Copy link
Copy Markdown
Member Author

Aed-1 commented Mar 21, 2026

image image

after careful consideration and testing, i have concluded that this works as intended, you can see the before and after above. (first screenshot is before, and second screenshot is after)

ButterscotchV
ButterscotchV approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sounds good

@gorbit99
Copy link
Copy Markdown
Contributor

gorbit99 commented Mar 21, 2026

image image

after careful consideration and testing, i have concluded that this works as intended, you can see the before and after above. (first screenshot is before, and second screenshot is after)

Hmm, the above image is redder, have you made sure that this isn't a regression caused by the change?

@Aed-1
Copy link
Copy Markdown
Member Author

Aed-1 commented Mar 21, 2026

the first screenshot was taken by someone else using a different theme. but i can look into it.
..
.....
.........

ok i looked into it, looks fine to me

@kounocom
Copy link
Copy Markdown
Contributor

kounocom commented Mar 21, 2026

Please provide a 3-page technical report on your testing process to ensure this doesn't break anything

@HannahPadd
Copy link
Copy Markdown

HannahPadd commented Mar 21, 2026

Can you please write an unit test to test this change?

@Spazznyan
Copy link
Copy Markdown
Contributor

Spazznyan commented Apr 3, 2026

to stay in line with i2c specs we should keep the 2 c's. mayb even add a third one for i3c future proofing

@kounocom
Copy link
Copy Markdown
Contributor

kounocom commented Apr 3, 2026

Please fix merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sctanf sctanf sctanf approved these changes

@kounocom kounocom kounocom approved these changes

@ImSapphire ImSapphire ImSapphire approved these changes

@TheDevMinerTV TheDevMinerTV TheDevMinerTV approved these changes

@gorbit99 gorbit99 gorbit99 approved these changes

@JovannMC JovannMC JovannMC approved these changes

@loucass003 loucass003 loucass003 approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@SummerSigh SummerSigh SummerSigh approved these changes

@ZRock35 ZRock35 ZRock35 approved these changes

@ShineBrightMeow ShineBrightMeow ShineBrightMeow approved these changes

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel

+2 more reviewers

@kruemmelbande kruemmelbande kruemmelbande approved these changes

@ashyfire33 ashyfire33 ashyfire33 approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Area: Translation Improvements or additions to translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.