Skip to content

Comments

Consolidate server code#506

Queued
kmontemayor2-sc wants to merge 10 commits intomainfrom
kmonte/consolidate-storage-code
Queued

Consolidate server code#506
kmontemayor2-sc wants to merge 10 commits intomainfrom
kmonte/consolidate-storage-code

Conversation

@kmontemayor2-sc
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Feb 23, 2026 •
edited
Loading

Scope of work done

As mentioned previously, we should consolidate the two "server mains" we had, I think now is a good time to do so :)

This PR removes the "built-in" gigl server in lieu of only exposing the example server, and adding some gigl utils to help run the server

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/e2e_test

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/integration_test

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/unit_test_py

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 19:38:19UTC : 🔄 E2E Test started.

@ 21:02:06UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 19:38:29UTC : 🔄 Integration Test started.

@ 20:59:42UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 19:38:41UTC : 🔄 Python Unit Test started.

@ 20:52:28UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/e2e_test

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/integration_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 21:30:28UTC : 🔄 Integration Test started.

@ 22:49:32UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 21:30:33UTC : 🔄 E2E Test started.

@ 22:58:23UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/unit_test_py

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 21:41:42UTC : 🔄 Python Unit Test started.

@ 22:53:46UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 23, 2026

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

GiGL Automation

@ 23:12:24UTC : 🔄 E2E Test started.

@ 24:33:13UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/e2e_test

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/integration_test

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/unit_test_py

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 05:06:57UTC : 🔄 E2E Test started.

@ 06:29:15UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 05:07:03UTC : 🔄 Integration Test started.

@ 06:42:51UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 05:07:09UTC : 🔄 Python Unit Test started.

@ 06:19:06UTC : ✅ Workflow completed successfully.

mkolodner-sc
mkolodner-sc reviewed Feb 24, 2026
View reviewed changes
Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! Left some comments/questions

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/all_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 18:37:25UTC : 🔄 Scala Unit Test started.

@ 18:45:15UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 18:37:26UTC : 🔄 Lint Test started.

@ 18:44:43UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 18:37:27UTC : 🔄 Python Unit Test started.

@ 19:48:02UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 18:37:27UTC : 🔄 E2E Test started.

@ 20:06:17UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 18:37:31UTC : 🔄 Integration Test started.

@ 19:49:38UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 19:15:49UTC : 🔄 E2E Test started.

@ 20:35:49UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/all_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 19:26:14UTC : 🔄 Integration Test started.

@ 20:42:03UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 19:26:15UTC : 🔄 Lint Test started.

@ 19:33:15UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 19:26:15UTC : 🔄 E2E Test started.

@ 20:44:00UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 19:26:19UTC : 🔄 Scala Unit Test started.

@ 19:36:33UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 19:26:20UTC : 🔄 Python Unit Test started.

@ 20:52:32UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Collaborator Author

kmontemayor2-sc commented Feb 24, 2026

/all_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 21:17:58UTC : 🔄 Lint Test started.

@ 21:25:10UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 21:17:59UTC : 🔄 Scala Unit Test started.

@ 21:26:48UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 21:17:59UTC : 🔄 Integration Test started.

@ 22:46:26UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 21:18:01UTC : 🔄 E2E Test started.

@ 22:41:07UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

GiGL Automation

@ 21:18:07UTC : 🔄 Python Unit Test started.

@ 22:42:36UTC : ✅ Workflow completed successfully.

mkolodner-sc
mkolodner-sc approved these changes Feb 24, 2026
View reviewed changes
Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! LGTM provided tests pass and no performance changes with this change

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review February 24, 2026 22:57
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Feb 25, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliu2-sc yliu2-sc yliu2-sc approved these changes

@mkolodner-sc mkolodner-sc mkolodner-sc approved these changes

@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner

@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner

@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner

@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmontemayor2-sc @yliu2-sc @mkolodner-sc @kmonte